<div dir="ltr">I patched that in and it works for me.<div><br></div><div>Thanks!</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Dec 13, 2022 at 1:47 PM Even Rouault <<a href="mailto:even.rouault@spatialys.com">even.rouault@spatialys.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p>Hi Kurt,</p>
<p>thanks for the feedback (and invalidating my prophecy that rc2
would be the last one :-))</p>
<p>should be fixed with
<a href="https://gitlab.com/libtiff/libtiff/-/merge_requests/444" target="_blank">https://gitlab.com/libtiff/libtiff/-/merge_requests/444</a>.</p>
<p>Is that enough to get the build working for you before I generate
a rc3 with that extra fix ?<br>
</p>
<p>Even<br>
</p>
<div>Le 13/12/2022 à 22:39, Kurt Schwehr a
écrit :<br>
</div>
<blockquote type="cite">
<div dir="ltr">I'm seeing mac osx and ios failures at my most
recent sync of <a rel="nofollow noopener" href="https://www.google.com/url?sa=D&q=https%3A%2F%2Fgitlab.com%2Flibtiff%2Flibtiff%2Fcommit%2Fc4516f9dc72bad7f2c4a8f704169afa0342e44ca" style="font-family:monospace;font-size:13px;white-space:pre-wrap" target="_blank">c4516f9dc72bad7f2c4a8f704169afa0342e44ca</a>:
<div><br>
</div>
<div>third_party/tiff/libtiff/tif_dir.c:1988:17: error: format
specifies type 'unsigned short' but the argument has type
'tdir_t' (aka 'unsigned int') [-Werror,-Wformat]<br>
*nextdirnum, *nextdiroff, *nextdiroff,
(int)(*nextdirnum) - 1);<br>
^~~~~~~~~~~<br>
third_party/tiff/libtiff/tif_dir.c:2164:27: error: format
specifies type 'unsigned short' but the argument has type
'tdir_t' (aka 'unsigned int') [-Werror,-Wformat]<br>
dirn);<br>
^~~~<br>
</div>
<div><br>
</div>
<div><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Dec 13, 2022 at 12:39
PM Even Rouault <<a href="mailto:even.rouault@spatialys.com" target="_blank">even.rouault@spatialys.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
The changes in IFD loop detection are non-trivial enough to
justify a <br>
rc2, so here it is:<br>
<br>
- <a href="https://download.osgeo.org/libtiff/tiff-4.5.0rc2.tar.gz" rel="noreferrer" target="_blank">https://download.osgeo.org/libtiff/tiff-4.5.0rc2.tar.gz</a><br>
- <a href="https://download.osgeo.org/libtiff/tiff-4.5.0rc2.tar.gz.sig" rel="noreferrer" target="_blank">https://download.osgeo.org/libtiff/tiff-4.5.0rc2.tar.gz.sig</a><br>
- <a href="https://download.osgeo.org/libtiff/tiff-4.5.0rc2.tar.xz" rel="noreferrer" target="_blank">https://download.osgeo.org/libtiff/tiff-4.5.0rc2.tar.xz</a><br>
- <a href="https://download.osgeo.org/libtiff/tiff-4.5.0rc2.tar.xz.sig" rel="noreferrer" target="_blank">https://download.osgeo.org/libtiff/tiff-4.5.0rc2.tar.xz.sig</a><br>
- <a href="https://download.osgeo.org/libtiff/tiff-4.5.0rc2.zip" rel="noreferrer" target="_blank">https://download.osgeo.org/libtiff/tiff-4.5.0rc2.zip</a><br>
- <a href="https://download.osgeo.org/libtiff/tiff-4.5.0rc2.zip.sig" rel="noreferrer" target="_blank">https://download.osgeo.org/libtiff/tiff-4.5.0rc2.zip.sig</a><br>
<br>
Hopefully this will be the final release candidate for 4.5.0.
Please <br>
test and report.<br>
<br>
The changes since rc1 are:<br>
- restore formatting of tiffvers.h so that FindTIFF.cmake can
infer <br>
libtiff version number<br>
- addition of TIFFLIB_MAJOR_VERSION, TIFFLIB_MINOR_VERSION, <br>
TIFFLIB_MICRO_VERSION in tiffvers.h<br>
- introduction of TIFFLIB_AT_LEAST(major, minor, micro) macro
in tiffvers.h<br>
- CMake: restore BUILD_SHARED_LIBS=ON default setting for
top-level builds<br>
- IFD loop detection: changed algorithm to use a
hashset/hashmap for <br>
good performance<br>
- tdir_t type updated to uint32_t. This type is now used for
the return <br>
value of TIFFCurrentDirectory and TIFFNumberOfDirectories, and
as the <br>
argument of TIFFSetDirectory and TIFFUnlinkDirectory<br>
- Increase the maximum number of IFDs that libtiff can browse
through <br>
from 65535 to 1048576. This value is a build-time setting,
available in <br>
tif_config.h, that can be configured with CMake's
TIFF_MAX_DIR_COUNT and <br>
variable or autoconf's --with-max-dir-count option.<br>
- tiffinfo: support more than 64k IFDs.<br>
<br>
Even<br>
<br>
-- <br>
<a href="http://www.spatialys.com" rel="noreferrer" target="_blank">http://www.spatialys.com</a><br>
My software is free, but my time generally not.<br>
<br>
_______________________________________________<br>
Tiff mailing list<br>
<a href="mailto:Tiff@lists.osgeo.org" target="_blank">Tiff@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/tiff" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/tiff</a><br>
</blockquote>
</div>
</blockquote>
<pre cols="72">--
<a href="http://www.spatialys.com" target="_blank">http://www.spatialys.com</a>
My software is free, but my time generally not.</pre>
</div>
</blockquote></div>