<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Paul,</p>
<p>I've queued your proposed fix in pull request
<a class="moz-txt-link-freetext" href="https://github.com/OSGeo/gdal/pull/6943">https://github.com/OSGeo/gdal/pull/6943</a></p>
<p>Even<br>
</p>
<div class="moz-cite-prefix">Le 18/12/2022 à 22:18, Paul Meems a
écrit :<br>
</div>
<blockquote type="cite"
cite="mid:CAHNf2YRrJagwLrSszjXZ9M3SfmvgyO2kPU1gXaU7g5TAZZ2sBA@mail.gmail.com">
<div dir="auto">
<div>I made the brackets bold. That seems to result in the *
<div dir="auto">Only ( and ) are needed, no *.</div>
<div dir="auto"><br>
</div>
Regards, </div>
<div dir="auto">Paul<br>
<br>
<div class="gmail_quote" dir="auto">
<div dir="ltr" class="gmail_attr">Op zo 18 dec. 2022 18:39
schreef Andrew C Aitchison <<a
href="mailto:andrew@aitchison.me.uk"
moz-do-not-send="true" class="moz-txt-link-freetext">andrew@aitchison.me.uk</a>>:<br>
</div>
<blockquote class="gmail_quote">On Sun, 18 Dec 2022, Paul
Meems wrote:<br>
<br>
> Thanks all for your suggestions.<br>
> I did some more research and it seems to be an issue
with the preprocessor<br>
> on Windows.<br>
><br>
> Adding some brackets solves the issue as well:<br>
> // old<br>
> constexpr int64_t GDAL_PAM_DEFAULT_NODATA_VALUE_INT64
=<br>
> std::numeric_limits<int64_t>::min();<br>
> constexpr
uint64_tGDAL_PAM_DEFAULT_NODATA_VALUE_UINT64=<br>
> std::numeric_limits<uint64_t>::max();<br>
> // new:<br>
> constexpr int64_t GDAL_PAM_DEFAULT_NODATA_VALUE_INT64
=*(*<br>
> std::numeric_limits<int64_t>::min*)*();<br>
> constexpr uint64_t
GDAL_PAM_DEFAULT_NODATA_VALUE_UINT64 =*(*<br>
> std::numeric_limits<uint64_t>::max*)*();<br>
<br>
Do you mean to add *(* and *)* or just ( and ) ?<br>
<br>
> I'm not sure what the impact would be for non-windows
compilers, but if no<br>
> impact could this be changed in the code?<br>
><br>
> Thanks,<br>
><br>
> Paul Meems<br>
><br>
><br>
> Op za 17 dec. 2022 om 07:10 schreef <<a
href="mailto:dg0yt@darc.de" target="_blank"
rel="noreferrer" moz-do-not-send="true"
class="moz-txt-link-freetext">dg0yt@darc.de</a>>:<br>
><br>
>> I'm not using MSVC, so this is a guess:<br>
>> Are you including 'windows.h' without 'NOMINMAX'
being defined?<br>
>> Then you will get macros which interfere with the
limits code.<br>
>><br>
>> Regards, Kai.<br>
>><br>
>>> Paul Meems <<a
href="mailto:bontepaarden@gmail.com" target="_blank"
rel="noreferrer" moz-do-not-send="true"
class="moz-txt-link-freetext">bontepaarden@gmail.com</a>>
hat am 17.12.2022 00:46 CET<br>
>> geschrieben:<br>
>>><br>
>>><br>
>>> Thanks, Kurt for your response.<br>
>>><br>
>>> I'm getting a very vague error message:<br>
>>> E0040 expected an identifier.<br>
>>><br>
>>><br>
>>> Regards,<br>
>>><br>
>>> Paul<br>
>>><br>
>>><br>
>>> Op za 17 dec. 2022 om 00:40 schreef Kurt
Schwehr <<a href="mailto:schwehr@gmail.com"
target="_blank" rel="noreferrer" moz-do-not-send="true"
class="moz-txt-link-freetext">schwehr@gmail.com</a>>:<br>
>>>> What exact error are you getting?<br>
>>>><br>
>>>><br>
>>>> On Fri, Dec 16, 2022 at 3:31 PM Paul
Meems <<a href="mailto:bontepaarden@gmail.com"
target="_blank" rel="noreferrer" moz-do-not-send="true"
class="moz-txt-link-freetext">bontepaarden@gmail.com</a>><br>
>> wrote:<br>
>>>>> Hello List,<br>
>>>>><br>
>>>>> We're trying to update MapWinGIS
which is using the GDAL libraries<br>
>> from <a href="http://gisinternals.com"
rel="noreferrer noreferrer" target="_blank"
moz-do-not-send="true">gisinternals.com</a> (<a
href="http://gisinternals.com" rel="noreferrer
noreferrer" target="_blank" moz-do-not-send="true"
class="moz-txt-link-freetext">http://gisinternals.com</a>)<br>
>>>>> Currently, we use the stable daily of
December<br>
>> 9: release-1928-gdal-3-5-mapserver-8-0<br>
>>>>><br>
>>>>> I'm using VS2019 (on Windows) to
compile and I'm having issues with<br>
>> two lines in gdal_pam.h, around line 215.<br>
>>>>> We need to change these two lines:<br>
>>>>><br>
>>>>> * constexpr int64_t
GDAL_PAM_DEFAULT_NODATA_VALUE_INT64 =<br>
>> std::numeric_limits<int64_t>::min();<br>
>>>>> * constexpr uint64_t
GDAL_PAM_DEFAULT_NODATA_VALUE_UINT64 =<br>
>> std::numeric_limits<uint64_t>::max();<br>
>>>>> To<br>
>>>>> * constexpr int64_t
GDAL_PAM_DEFAULT_NODATA_VALUE_INT64 =<br>
>> LLONG_MIN;<br>
>>>>> * constexpr uint64_t
GDAL_PAM_DEFAULT_NODATA_VALUE_UINT64 =<br>
>> LLONG_MAX;<br>
>>>>> I prefer not to alter the files from
<a href="http://gisinternals.com" rel="noreferrer
noreferrer" target="_blank" moz-do-not-send="true">gisinternals.com</a>
(<br>
>> <a href="http://gisinternals.com"
rel="noreferrer noreferrer" target="_blank"
moz-do-not-send="true" class="moz-txt-link-freetext">http://gisinternals.com</a>).
Is this what we can solve on our end?<br>
>>>>> Is it related to the C++ version? We
use these:<br>
>>>>><br>
>>>>> * ISO C++14 Standard (/std:c++14)<br>
>>>>> * ISO C11 Standard (/std:c11)<br>
>>>>> Thanks for any advice.<br>
>>>>><br>
>>>>> Paul Meems<br>
>>>>><br>
>>>>>
_______________________________________________<br>
>>>>> gdal-dev mailing list<br>
>>>>> <a
href="mailto:gdal-dev@lists.osgeo.org" target="_blank"
rel="noreferrer" moz-do-not-send="true"
class="moz-txt-link-freetext">gdal-dev@lists.osgeo.org</a><br>
>>>>> <a
href="https://lists.osgeo.org/mailman/listinfo/gdal-dev"
rel="noreferrer noreferrer" target="_blank"
moz-do-not-send="true" class="moz-txt-link-freetext">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
>>>>><br>
>>>
_______________________________________________<br>
>>> gdal-dev mailing list<br>
>>> <a href="mailto:gdal-dev@lists.osgeo.org"
target="_blank" rel="noreferrer" moz-do-not-send="true"
class="moz-txt-link-freetext">gdal-dev@lists.osgeo.org</a><br>
>>> <a
href="https://lists.osgeo.org/mailman/listinfo/gdal-dev"
rel="noreferrer noreferrer" target="_blank"
moz-do-not-send="true" class="moz-txt-link-freetext">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
>> _______________________________________________<br>
>> gdal-dev mailing list<br>
>> <a href="mailto:gdal-dev@lists.osgeo.org"
target="_blank" rel="noreferrer" moz-do-not-send="true"
class="moz-txt-link-freetext">gdal-dev@lists.osgeo.org</a><br>
>> <a
href="https://lists.osgeo.org/mailman/listinfo/gdal-dev"
rel="noreferrer noreferrer" target="_blank"
moz-do-not-send="true" class="moz-txt-link-freetext">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
>><br>
><br>
<br>
-- <br>
Andrew C. Aitchison Kendal, UK<br>
<a
href="mailto:andrew@aitchison.me.uk" target="_blank"
rel="noreferrer" moz-do-not-send="true"
class="moz-txt-link-freetext">andrew@aitchison.me.uk</a><br>
</blockquote>
</div>
</div>
</div>
<br>
<fieldset class="moz-mime-attachment-header"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
gdal-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a>
<a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/gdal-dev">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a>
</pre>
</blockquote>
<pre class="moz-signature" cols="72">--
<a class="moz-txt-link-freetext" href="http://www.spatialys.com">http://www.spatialys.com</a>
My software is free, but my time generally not.</pre>
</body>
</html>