<div dir="auto"><div>Thank you, gosh that does help explain a lot.</div><div dir="auto"><br></div><div dir="auto">Cheers, Mike<br><br><div class="gmail_quote" dir="auto"><div dir="ltr" class="gmail_attr">On Wed, 8 Feb 2023, 21:42 Thomas Knudsen, <<a href="mailto:knudsen.thomas@gmail.com">knudsen.thomas@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">>
Ah ok, mostly I was just confused why it's not an error for the compiler<div><br></div><div>The compiler only needs to know the type of the argument - in a header file, the identifier name following</div><div>the type is for human information only</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br></blockquote><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Den ons. 8. feb. 2023 kl. 00.49 skrev Michael Sumner <<a href="mailto:mdsumner@gmail.com" target="_blank" rel="noreferrer">mdsumner@gmail.com</a>>:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Feb 8, 2023 at 10:44 AM Even Rouault <<a href="mailto:even.rouault@spatialys.com" target="_blank" rel="noreferrer">even.rouault@spatialys.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p>Michael,</p>
<p>Feel free to submit a fix as there's obviously no justification
for the discrepancy other than just being accidental.<br></p></div></blockquote><div><br></div><div>Ah ok, mostly I was just confused why it's not an error for the compiler ... but I'm getting used to surprises learning C++ :)</div><div><br></div><div>PR incoming, thanks!</div><div><br></div><div>Cheers, Mike</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><p>
</p>
<p>There are likely hundreds of similar occurrences in the code
base. I believe there's a compiler warning (or at least cppcheck)
to detect this, but it is not activated. <br>
</p>
<p>Even<br>
</p>
<div>Le 08/02/2023 à 00:35, Michael Sumner a
écrit :<br>
</div>
<blockquote type="cite">
<div dir="ltr">This is not causing any problems afaict, but I
happened to notice the plural for 'padfExtents' in the
gdal_alg.h signature for GDALSuggestedWarpOutput2 compared to
gdaltransformer.cpp
<div><br>
</div>
<div><a href="https://github.com/OSGeo/gdal/blob/579693c2975cda414af75239e09b8b7b952029ca/alg/gdal_alg.h#L264" target="_blank" rel="noreferrer">https://github.com/OSGeo/gdal/blob/579693c2975cda414af75239e09b8b7b952029ca/alg/gdal_alg.h#L264</a></div>
<div><br>
</div>
<div><a href="https://github.com/OSGeo/gdal/blob/579693c2975cda414af75239e09b8b7b952029ca/alg/gdaltransformer.cpp#L412" target="_blank" rel="noreferrer">https://github.com/OSGeo/gdal/blob/579693c2975cda414af75239e09b8b7b952029ca/alg/gdaltransformer.cpp#L412</a><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>The discrepancy is visible in the doc here: </div>
<div><br>
</div>
<div><a href="https://gdal.org/api/gdal_alg.html#_CPPv424GDALSuggestedWarpOutput212GDALDatasetH19GDALTransformerFuncPvPdPiPiPdi" target="_blank" rel="noreferrer">https://gdal.org/api/gdal_alg.html#_CPPv424GDALSuggestedWarpOutput212GDALDatasetH19GDALTransformerFuncPvPdPiPiPdi</a><br>
</div>
<div><br>
</div>
<div>Cheers, Mike</div>
<div><br>
</div>
<div><br>
<div><br>
</div>
-- <br>
<div dir="ltr">Michael Sumner<br>
Software and Database Engineer<br>
Australian Antarctic Division<br>
Hobart, Australia<br>
e-mail: <a href="mailto:mdsumner@gmail.com" target="_blank" rel="noreferrer">mdsumner@gmail.com</a></div>
</div>
</div>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
gdal-dev mailing list
<a href="mailto:gdal-dev@lists.osgeo.org" target="_blank" rel="noreferrer">gdal-dev@lists.osgeo.org</a>
<a href="https://lists.osgeo.org/mailman/listinfo/gdal-dev" target="_blank" rel="noreferrer">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a>
</pre>
</blockquote>
<pre cols="72">--
<a href="http://www.spatialys.com" target="_blank" rel="noreferrer">http://www.spatialys.com</a>
My software is free, but my time generally not.</pre>
</div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr">Michael Sumner<br>Software and Database Engineer<br>Australian Antarctic Division<br>Hobart, Australia<br>e-mail: <a href="mailto:mdsumner@gmail.com" target="_blank" rel="noreferrer">mdsumner@gmail.com</a></div></div>
_______________________________________________<br>
gdal-dev mailing list<br>
<a href="mailto:gdal-dev@lists.osgeo.org" target="_blank" rel="noreferrer">gdal-dev@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/gdal-dev" rel="noreferrer noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
</blockquote></div>
</blockquote></div></div></div>