<div dir="ltr">My personal take: <div><br></div><div>I slightly Hungarian notation and it seems to me like needing that extra notation points to other coding style issues. However, I think moving away from it would be a chaotic mess for GDAL. It would be a massive change to switch it all. Consistency is critical.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 17, 2024 at 9:10 AM Even Rouault via gdal-dev <<a href="mailto:gdal-dev@lists.osgeo.org">gdal-dev@lists.osgeo.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><u></u>
<div>
<p>Hi,</p>
<p>This is described in
<a href="https://gdal.org/development/rfc/rfc8_devguide.html" target="_blank">https://gdal.org/development/rfc/rfc8_devguide.html</a> . I've
submitted <a href="https://github.com/OSGeo/gdal/pull/9689" target="_blank">https://github.com/OSGeo/gdal/pull/9689</a> so it is going
to be linked to
<a href="https://gdal.org/development/dev_practices.html#making-changes-to-gdal" target="_blank">https://gdal.org/development/dev_practices.html#making-changes-to-gdal</a></p>
<p>I'd probably agree that at my beginnings in GDAL, I might have
felt unfamiliar with the Hungarian notation, but now I've fully
internalized it, so I hardly notice it. It would be interesting to
have opinions of other developers if they find it inconvenient/a
hurdle, are neutral or like it. The thing is that if we decide to
no longer use it, the inconsistency of mixing free style naming
and Hungarian notation might be problematic and make code
confusing. We should probably aim at being consistent at least at
the scope of a given function or file.</p>
<p>Even<br>
</p>
<div>Le 17/04/2024 à 15:48, Andrew Bell via
gdal-dev a écrit :<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi,
<div><br>
</div>
<div>I was going to make some changes to some GDAL code and I
generally want to follow along. I see that most of the code is
still using Hungarian notation for identifier names. I haven't
seen this anywhere else in like 20 years.<br>
<br>
Is it OK to submit code without this naming convention or do
we still think it's important. I didn't see an RFC or
documentation that covers this, but there's lots so I may have
missed it.<br>
<br>
Thanks,<br clear="all">
<div><br>
</div>
<span class="gmail_signature_prefix">-- </span><br>
<div dir="ltr" class="gmail_signature">Andrew Bell<br>
<a href="mailto:andrew.bell.ia@gmail.com" target="_blank">andrew.bell.ia@gmail.com</a></div>
</div>
</div>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
gdal-dev mailing list
<a href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a>
<a href="https://lists.osgeo.org/mailman/listinfo/gdal-dev" target="_blank">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a>
</pre>
</blockquote>
<pre cols="72">--
<a href="http://www.spatialys.com" target="_blank">http://www.spatialys.com</a>
My software is free, but my time generally not.</pre>
</div>
_______________________________________________<br>
gdal-dev mailing list<br>
<a href="mailto:gdal-dev@lists.osgeo.org" target="_blank">gdal-dev@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/gdal-dev" rel="noreferrer" target="_blank">https://lists.osgeo.org/mailman/listinfo/gdal-dev</a><br>
</blockquote></div>