[GeoNode-devel] flake8: problems detecting unused imports

[Simone Dalmasso]

Paolo I cannot replicate this, I just created a new venv and installed
geonode in it and I see the pep8 violations.
here my versions 2.3.0 (pep8: 1.6.2, pyflakes: 0.8.1, mccabe: 0.3) CPython
2.7.6 on Linux

2015-03-10 14:15 GMT+01:00 Paolo Corti <pcorti at gmail.com>:

> They are already in my virtualenv, installed by the geonode setup
> process. I updated pep8 to 1.6.2 but no joy:
>
> flake8==2.3.0
> mccabe==0.3
> pep8==1.6.2
> pyflakes==0.8.1
>
> Simone, can you replicate this in your development computer?
> Try to recreate a virtualenv and see if it happens to you as well
> p
>
> On Tue, Mar 10, 2015 at 2:01 PM, Simone Dalmasso
> <simone.dalmasso at gmail.com> wrote:
> > Do you think that we should specify all the components? pyflakes and
> mccabe.
> >
> > 2015-03-10 13:52 GMT+01:00 Paolo Corti <pcorti at gmail.com>:
> >>
> >> for what is worth not even updating pep from 1.5.7 to 1.6.2 seems to fix
> >> things.
> >> cheers
> >> p
> >>
> >> On Tue, Mar 10, 2015 at 1:49 PM, Simone Dalmasso
> >> <simone.dalmasso at gmail.com> wrote:
> >> > The strange thing is that we have specified the pep8 version in
> setup.py
> >> > https://github.com/GeoNode/geonode/blob/master/setup.py#L146, I'm
> sure
> >> > that
> >> > the reason of the issue si the old version of pep8 but why is not
> >> > installed
> >> > with setup.py?
> >> >
> >> > 2015-03-10 12:36 GMT+01:00 Paolo Corti <pcorti at gmail.com>:
> >> >>
> >> >> Hi devs
> >> >>
> >> >> today I am experiencing a weird problem with the flake8 and its
> >> >> dependencies that come installed with GeoNode in a virtualenv. This
> >> >> flake8 seems not to be able to recognize unused imports.
> >> >>
> >> >> How to replicate:
> >> >> $ virtualenv --no-site-packages env
> >> >> $ . env/bin/activate
> >> >> $ pip install -e .
> >> >>
> >> >> now if I run flake8 the unused imports are not detected.
> >> >>
> >> >> This is what I have:
> >> >> $ flake8 --version
> >> >> 2.3.0 (pep8: 1.5.7) CPython 2.7.3 on Linux
> >> >>
> >> >> Instead if I create a fresh virtualenv and I just install flake8 it
> >> >> seems to work (note the output of flake8 --version, it is different
> >> >> and seems containing references to pyflakes and mccabe):
> >> >>
> >> >> $ virtualenv --no-site-packages env_flake8
> >> >> $ . env_flake8/bin/activate
> >> >> $ pip install flake8==2.3.0
> >> >> $ flake8 --version
> >> >> 2.3.0 (pep8: 1.6.2, pyflakes: 0.8.1, mccabe: 0.3) CPython 2.7.3 on
> >> >> Linux
> >> >> $ flake8 geonode
> >> >> geonode/geoserver/tests.py:10:1: F401 'Client' imported but unused
> >> >> geonode/tests/smoke.py:22:1: F401 'Client' imported but unused
> >> >> geonode/documents/tests.py:10:1: F401 'Client' imported but unused
> >> >> geonode/people/tests.py:21:1: F401 'Client' imported but unused
> >> >> geonode/tests/integration.py:32:1: F401 'Client' imported but unused
> >> >>
> >> >> any idea of what can be causing the failure?
> >> >> thanks
> >> >> p
> >> >>
> >> >> --
> >> >> Paolo Corti
> >> >> Geospatial software developer
> >> >> web: http://www.paolocorti.net
> >> >> twitter: @capooti
> >> >> skype: capooti
> >> >> _______________________________________________
> >> >> geonode-devel mailing list
> >> >> geonode-devel at lists.osgeo.org
> >> >> http://lists.osgeo.org/cgi-bin/mailman/listinfo/geonode-devel
> >> >
> >> >
> >> >
> >> >
> >> > --
> >> > Simone
> >>
> >>
> >>
> >> --
> >> Paolo Corti
> >> Geospatial software developer
> >> web: http://www.paolocorti.net
> >> twitter: @capooti
> >> skype: capooti
> >
> >
> >
> >
> > --
> > Simone
>
>
>
> --
> Paolo Corti
> Geospatial software developer
> web: http://www.paolocorti.net
> twitter: @capooti
> skype: capooti
>



-- 
Simone
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/geonode-devel/attachments/20150310/1350d697/attachment-0001.html>