[GeoNode-devel] Excluding remote layers from Download Map feature?

[Craig Stephenson]

Hi All,

My colleagues and I discovered that an exception is produced if you add a
remote layer (via the Remote Services feature) to a map, then try to
download the map by going to:

Download Map -> Download Data Layers -> Start downloading this map

We modified GeoNode to skip over Remote Services layers like this:

https://github.com/ua-snap/geonode/commit/c23d8d19b65328901145a5d74e12f98f4aa0e537

Is this a reasonable fix? And if so, should I submit this as a PR to your
project?

Some context: I had tried making a map with a Shapefile layer, a GeoTIFF
layer, and a Remote Services layer. The j_layer["service"] value for each
shows up as:

Shapefile: WFS
GeoTIFF: WCS
Remote Services: None

Which is why I'm performing this check:

if j_layer["service"] is None

Or would it be better to do something like this?

if j_layer["service"] is not "WFS" and j_layer["service"] is not "WCS"

Thanks,
Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/geonode-devel/attachments/20160829/f2aabf0f/attachment.html>