<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">No worries; I wasn't contacting you to
say you shouldn't move forward; just that you should join in and
implement your ideas on the importer instead of directly in
GeoNode. It will be a bit before I turn my attention to enabling
fgdb imports. Definitely get in touch if you plan to move
forward. If it's down the road some I'd be happy to work
together, if it's sooner I can offer some support to get you going
with the importer.<br>
<br>
Best, Jivan<br>
<br>
On 12/12/2016 07:07 AM, Simone Dalmasso wrote:<br>
</div>
<blockquote
cite="mid:CAAHAC+cOBeWSoBDg_MtrsRku5FwBgf=3tTfkn45JZbjC5kycAg@mail.gmail.com"
type="cite">
<div dir="ltr">Rollback, apologyze,
<div><br>
</div>
<div>you are working on the importer already, so I'll leave to
who is directly involved too.</div>
<div><br>
</div>
<div>Thanks!</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2016-12-12 16:01 GMT+01:00 Simone
Dalmasso <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:simone.dalmasso@gmail.com" target="_blank">simone.dalmasso@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hi Jivan,
<div><br>
</div>
<div>this interesting indeed, though the community is
working on the <a moz-do-not-send="true"
href="https://github.com/GeoNode/django-osgeo-importer"
target="_blank">https://github.com/<wbr>GeoNode/django-osgeo-importer</a>
which will be used in GeoNode soon as default way to
import data. Do you think that your work can fit in that
one?</div>
</div>
<div class="gmail_extra">
<div>
<div class="h5"><br>
<div class="gmail_quote">2016-12-05 19:59 GMT+01:00
Jivan Amara <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:development@jivanamara.net"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:development@jivanamara.net">development@jivanamara.net</a></a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
> ------------------------------<wbr>------------------------------<wbr>----------<br>
><br>
> Message: 1<br>
> Date: Fri, 25 Nov 2016 15:52:17 +0000<br>
> From: Eric Groning <<a
moz-do-not-send="true"
href="mailto:eg@novel-t.ch" target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:eg@novel-t.ch">eg@novel-t.ch</a></a>><br>
> To: "<a moz-do-not-send="true"
href="mailto:geonode-devel@lists.osgeo.org"
target="_blank">geonode-devel@lists.osgeo.org</a><wbr>"
<<a moz-do-not-send="true"
href="mailto:geonode-devel@lists.osgeo.org"
target="_blank">geonode-devel@lists.osgeo.org</a><wbr>><br>
> Subject: [GeoNode-devel] Support for
additional types in upload<br>
> Message-ID:<br>
> <<a moz-do-not-send="true"
href="mailto:VI1PR04MB1181179E9070D8AD3FE1F96FFA890@VI1PR04MB1181.eurprd04.prod.outlook.com"
target="_blank">VI1PR04MB1181179E9070D8AD3FE<wbr>1F96FFA890@VI1PR04MB1181.eurpr<wbr>d04.prod.outlook.com</a>><br>
><br>
> Content-Type: text/plain;
charset="iso-8859-1"<br>
><br>
> Hello,<br>
><br>
> I'm currently adding FGDB support for the
upload for a project based on a customized
geonode. Since it might be a feature the
community is interested in, I figured it's worth
it to mention in this list. I also have a few
questions.<br>
><br>
> First, here is a rough outline of what I'm
changing:<br>
><br>
> -Use gdal 2.1.2 (the latest) compiled with
FileGDB support (via GDAL_LIBRARY_PATH in Django
settings)<br>
> -Change layer forms / upload / geoserver
signals to accept a zipped fgdb<br>
> -Change geoserver_pre_save to use call
ogr2ogr directly to convert the FGDB to the
geoserver data Postgis database (as geoserver
won't convert an uploaded FGDB as it does with
shapefiles)<br>
><br>
> Second, with regards to adding this to
geonode via pull request:<br>
><br>
> The implementation I'm doing wouldn't really
be directly merge-able. To do this properly,
there would likely need to be some refactoring
done to make the upload generic and extensible
(like to easily add more gdal supported types with
different file structures / extentions such as KML
/ Postgis backups / GML / SqLite / GeoJSON /
etc). The configuration would have impacts on
how the upload form is validated, the layer upload
javascript, the model, and how the layer is
uploaded to geoserver. So not a light / easy
change :)<br>
><br>
> A side issue is that for some formats, you
can have multiple layers. As such, it would be
nice to have the UI handle multiple layers (ie let
the user choose which layers to upload)<br>
><br>
> For reference, below are links to some
shapefile specific handling in the code --<br>
> <a moz-do-not-send="true"
href="https://github.com/GeoNode/geonode/blob/master/geonode/layers/utils.py#L94"
rel="noreferrer" target="_blank">https://github.com/GeoNode/geo<wbr>node/blob/master/geonode/layer<wbr>s/utils.py#L94</a><br>
> <a moz-do-not-send="true"
href="https://github.com/GeoNode/geonode/blob/master/geonode/layers/forms.py#L81"
rel="noreferrer" target="_blank">https://github.com/GeoNode/geo<wbr>node/blob/master/geonode/layer<wbr>s/forms.py#L81</a><br>
> <a moz-do-not-send="true"
href="https://github.com/GeoNode/geonode/blob/master/geonode/geoserver/helpers.py#L1084"
rel="noreferrer" target="_blank">https://github.com/GeoNode/geo<wbr>node/blob/master/geonode/geose<wbr>rver/helpers.py#L1084</a><br>
><br>
><br>
> The questions are:<br>
><br>
> Is supporting more types / making the upload
more generic a planned feature for a future
geonode release?<br>
><br>
> What would be the pros / cons to this
approach vs an approach like first converting the
upload to a shapefile (like in the layer_upload
view), then use the existing upload flow?<br>
><br>
> Any pain points / gotchas in the above
approach?<br>
><br>
><br>
> Best regards,<br>
> Eric<br>
><br>
> Novel-T Sàrl<br>
> Eric GRÖNING - Solutions Engineer<br>
> W: <a moz-do-not-send="true"
href="http://www.novel-t.ch" rel="noreferrer"
target="_blank">www.novel-t.ch</a><<a
moz-do-not-send="true"
href="http://www.novel-t.ch/" rel="noreferrer"
target="_blank"><a class="moz-txt-link-freetext" href="http://www.nove">http://www.nove</a><wbr>l-t.ch/</a>>
| @: <a moz-do-not-send="true"
href="mailto:eg@novel-t.ch" target="_blank">eg@novel-t.ch</a><mailto:<a
moz-do-not-send="true"
href="mailto:eg@novel-t.ch" target="_blank">eg@novel-<wbr>t.ch</a>><br>
><br>
Hi Eric,<br>
This project is for making uploads generic:<br>
<a moz-do-not-send="true"
href="https://github.com/geonode/django-osgeo-importer"
rel="noreferrer" target="_blank">https://github.com/geonode/dja<wbr>ngo-osgeo-importer</a>
and we're going to be<br>
working on FGDB support. The approach you
outlined looks good, I'd just<br>
suggest doing it as part of the importer.<br>
<span class="m_2331538631360167262HOEnZb"><font
color="#888888"><br>
--<br>
Cheers,<br>
Jivan Amara<br>
---<br>
Senior Software Developer / System
Administrator<br>
<a class="moz-txt-link-abbreviated" href="mailto:Development@JivanAmara.net">Development@JivanAmara.net</a><br>
<br>
<br>
______________________________<wbr>_________________<br>
geonode-devel mailing list<br>
<a moz-do-not-send="true"
href="mailto:geonode-devel@lists.osgeo.org"
target="_blank">geonode-devel@lists.osgeo.org</a><br>
<a moz-do-not-send="true"
href="http://lists.osgeo.org/mailman/listinfo/geonode-devel"
rel="noreferrer" target="_blank">http://lists.osgeo.org/mailman<wbr>/listinfo/geonode-devel</a><br>
</font></span></blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
</div>
</div>
<span class="HOEnZb"><font color="#888888">-- <br>
<div class="m_2331538631360167262gmail_signature"
data-smartmail="gmail_signature">Simone </div>
</font></span></div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div class="gmail_signature" data-smartmail="gmail_signature">Simone </div>
</div>
</blockquote>
<br>
</body>
</html>