<div dir="ltr">Thanks Jonathan, <div><br></div><div>These are nice proposals. I will add them.</div><div><br></div><div>Cheers</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 20, 2017 at 4:41 AM, Jonathan Doig <span dir="ltr"><<a href="mailto:j.doig@unsw.edu.au" target="_blank">j.doig@unsw.edu.au</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-AU" link="blue" vlink="purple">
<div class="m_3429332784367465882WordSection1">
<p class="MsoNormal"><span>Looks great, thanks Dimitris!<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span>May I suggest a tweak to the presentation to show/hide the Filter?<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span>Also if it’s possible to add a widget to set max features, this would be very handy when just wanting to get a quick sample of a big dataset.<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span>I’ve mocked up how these might look – attached. ‘Clear’ could both clear the filter and hide it again.<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span>Regards<u></u><u></u></span></p>
<p class="MsoNormal"><span>Jonathan<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> geonode-devel [mailto:<a href="mailto:geonode-devel-bounces@lists.osgeo.org" target="_blank">geonode-devel-bounces@<wbr>lists.osgeo.org</a>]
<b>On Behalf Of </b>Paolo Corti<br>
<b>Sent:</b> Wednesday, 20 September 2017 11:09 AM<br>
<b>To:</b> Angelos Tzotsos <<a href="mailto:gcpp.kalxas@gmail.com" target="_blank">gcpp.kalxas@gmail.com</a>><br>
<b>Cc:</b> geonode-devel <<a href="mailto:geonode-devel@lists.osgeo.org" target="_blank">geonode-devel@lists.osgeo.org</a><wbr>><br>
<b>Subject:</b> Re: [GeoNode-devel] Commit code in GeoNode master branch<u></u><u></u></span></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">+1 it is a long waited great feature :)<u></u><u></u></p>
<div>
<p class="MsoNormal">Thanks Dimitris!<u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Sep 19, 2017 19:29, "Angelos Tzotsos" <<a href="mailto:gcpp.kalxas@gmail.com" target="_blank">gcpp.kalxas@gmail.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<p class="MsoNormal">Thanks Dimitris!<br>
+1 to include as default<br>
<br>
Angelos<span class=""><br>
<br>
On 09/19/2017 04:15 PM, Patrick Dufour wrote:<u></u><u></u></span></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"><span class="">
<pre>Awesome! +1 to enable by default. We can add in some settings,<u></u><u></u></pre>
<pre>enumerations, etc. to give additional abstraction if necessary at a later<u></u><u></u></pre>
<pre>stage. This is a significant step forward for GeoNode UX. Thank you<u></u><u></u></pre>
<pre>Dimitris!<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>Patrick<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>On Sep 19, 2017 8:23 AM, "Francesco Bartoli" <a href="mailto:xbartolone@gmail.com" target="_blank"><xbartolone@gmail.com></a> wrote:<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
</span><blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"><span class="">
<pre>Great contribution Dimitri! +1 in the code base<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>Sent from Nylas Mail<u></u><u></u></pre>
</span><pre><a href="https://n1.nylas.com/link/72e0e9e7634d6c6f2a502dc7068f5361d905ee3269feda10a8072c3c9d4d1f86/0?redirect=https%3A%2F%2Fnylas.com%3Fref%3Dn1&recipient=geonode-devel%40lists.osgeo.org" target="_blank"><https://n1.nylas.com/link/<wbr>72e0e9e7634d6c6f2a502dc7068f53<wbr>61d905ee3269feda10a8072c3c9d4d<wbr>1f86/0?redirect=https%3A%2F%<wbr>2Fnylas.com%3Fref%3Dn1&<wbr>recipient=geonode-devel%<wbr>40lists.osgeo.org></a>,<u></u><u></u></pre><span class="">
<pre>the best free email app for work<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
</span><pre>On set 19 2017, at 1:04 pm, Simone Dalmasso <a href="mailto:simone.dalmasso@gmail.com" target="_blank"><simone.dalmasso@gmail.com></a><u></u><u></u></pre>
<pre>wrote:<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"><span class="">
<pre>Hi Dimitris,<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>I would definitely see this contribution as part of the core codebase<u></u><u></u></pre>
<pre>rather that having it as contrib optional app. Therefore I'm +1 in keeping<u></u><u></u></pre>
<pre>the js into layer_detail.html, while for css you could add it to the<u></u><u></u></pre>
<pre>base.less (that then you can compile minified into base.css).<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>If you have tests, the better but being mostly js, as I suppose, it's ok<u></u><u></u></pre>
<pre>without them as well as we don't have testing facilities in place for js.<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>While for the doc, it is in a dedicated folder into the main repo<u></u><u></u></pre>
<pre><a href="https://github.com/GeoNode/geonode/tree/master/docs" target="_blank">https://github.com/GeoNode/<wbr>geonode/tree/master/docs</a><u></u><u></u></pre>
</span><pre><a href="https://github.com/GeoNode/geonode/tree/master/docs?recipient=geonode-devel%40lists.osgeo.org" target="_blank"><https://github.com/GeoNode/<wbr>geonode/tree/master/docs?<wbr>recipient=geonode-devel%<wbr>40lists.osgeo.org></a>,<u></u><u></u></pre><span class="">
<pre>you can find the most convenient place in there.<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>Thanks a lot for this, very nice and welcome feature.<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>Let us know if you need further info.<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>Ciao<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>2017-09-19 10:33 GMT+02:00 Dimitris Karakostis <<u></u><u></u></pre>
<pre><a href="mailto:karakostis.dimitris@gmail.com" target="_blank">karakostis.dimitris@gmail.com</a>><wbr>:<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>Hi all,<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>I have integrated the Layer Filtering functionality in my local master<u></u><u></u></pre>
<pre>branch of GeoNode. The functionality gives the possibility to build basic<u></u><u></u></pre>
<pre>queries based on the layer's attributes and values and download part of the<u></u><u></u></pre>
<pre>layers (in the provided formats) (see screenshot). Currently it works for<u></u><u></u></pre>
<pre>local, vector layers.<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>In the past we have discussed this functionality here:<u></u><u></u></pre>
<pre><a href="https://goo.gl/7rTDzF" target="_blank">https://goo.gl/7rTDzF</a><u></u><u></u></pre>
</span><pre><a href="https://goo.gl/7rTDzF?recipient=geonode-devel%40lists.osgeo.org" target="_blank"><https://goo.gl/7rTDzF?<wbr>recipient=geonode-devel%<wbr>40lists.osgeo.org></a><u></u><u></u></pre><span class="">
<pre><u></u> <u></u></pre>
<pre>As this is my first contribution to the GeoNode community, I want to be<u></u><u></u></pre>
<pre>sure that the commit complies to best practices in terms of documentation,<u></u><u></u></pre>
<pre>potential tests and code.<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>Currently I have included CSS and javascript code in the<u></u><u></u></pre>
<pre>layer_detail.html. Should I move these snippets of code in external files?<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>How and where do I update the documentation?<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>Any advice on the above would be greatly appreciated.<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>Thanks.<u></u><u></u></pre>
<pre>Dimitris<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>______________________________<wbr>_________________<u></u><u></u></pre>
<pre>geonode-devel mailing list<u></u><u></u></pre>
<pre><a href="mailto:geonode-devel@lists.osgeo.org" target="_blank">geonode-devel@lists.osgeo.org</a><u></u><u></u></pre>
<pre><a href="https://lists.osgeo.org/mailman/listinfo/geonode-devel" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/geonode-devel</a><u></u><u></u></pre>
</span><pre><a href="https://lists.osgeo.org/mailman/listinfo/geonode-devel?recipient=geonode-devel%40lists.osgeo.org" target="_blank"><https://lists.osgeo.org/<wbr>mailman/listinfo/geonode-<wbr>devel?recipient=geonode-devel%<wbr>40lists.osgeo.org></a><u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre><u></u> <u></u></pre>
<pre><u></u> <u></u></pre>
<pre><u></u> <u></u></pre>
<pre>--<u></u><u></u></pre>
<pre>Simone<u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre>______________________________<wbr>_________________<u></u><u></u></pre>
<pre>geonode-devel mailing <a href="mailto:listgeonode-devel@lists.osgeo.orghttps://lists.osgeo.org/mailman/listinfo/geonode-devel" target="_blank">listgeonode-devel@lists.osgeo.<wbr>orghttps://lists.osgeo.org/<wbr>mailman/listinfo/geonode-devel</a><u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre><u></u> <u></u></pre>
</blockquote><span class="">
<pre>______________________________<wbr>_________________<u></u><u></u></pre>
<pre>geonode-devel mailing list<u></u><u></u></pre>
<pre><a href="mailto:geonode-devel@lists.osgeo.org" target="_blank">geonode-devel@lists.osgeo.org</a><u></u><u></u></pre>
<pre><a href="https://lists.osgeo.org/mailman/listinfo/geonode-devel" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/geonode-devel</a><u></u><u></u></pre>
<pre><u></u> <u></u></pre>
<pre><u></u> <u></u></pre>
</span></blockquote>
<pre><u></u> <u></u></pre>
<p class="MsoNormal" style="margin-bottom:12.0pt"><u></u> <u></u></p>
<pre>______________________________<wbr>_________________<u></u><u></u></pre><span class="">
<pre>geonode-devel mailing list<u></u><u></u></pre>
<pre><a href="mailto:geonode-devel@lists.osgeo.org" target="_blank">geonode-devel@lists.osgeo.org</a><u></u><u></u></pre>
<pre><a href="https://lists.osgeo.org/mailman/listinfo/geonode-devel" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/geonode-devel</a><u></u><u></u></pre>
</span></blockquote>
<p><u></u> <span class="HOEnZb"><font color="#888888"><u></u></font></span></p><span class="HOEnZb"><font color="#888888">
<pre>-- <u></u><u></u></pre>
<pre>Angelos Tzotsos, PhD<u></u><u></u></pre>
<pre>Charter Member<u></u><u></u></pre>
<pre>Open Source Geospatial Foundation<u></u><u></u></pre>
<pre><a href="http://users.ntua.gr/tzotsos" target="_blank">http://users.ntua.gr/tzotsos</a><u></u><u></u></pre>
</font></span></div><span class="">
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
______________________________<wbr>_________________<br>
geonode-devel mailing list<br>
<a href="mailto:geonode-devel@lists.osgeo.org" target="_blank">geonode-devel@lists.osgeo.org</a><br>
<a href="https://lists.osgeo.org/mailman/listinfo/geonode-devel" target="_blank">https://lists.osgeo.org/<wbr>mailman/listinfo/geonode-devel</a><u></u><u></u></p>
</span></blockquote>
</div>
</div>
</div>
</div>
</blockquote></div><br></div>