<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Thanks Dimitris!<br>
+1 to include as default<br>
<br>
Angelos<br>
<br>
On 09/19/2017 04:15 PM, Patrick Dufour wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAKv4Cpp_8MZJOThAXHRhheRy9EM6ofXtRnNWfo61Xv2xfZY3aA@mail.gmail.com">
<pre wrap="">Awesome! +1 to enable by default. We can add in some settings,
enumerations, etc. to give additional abstraction if necessary at a later
stage. This is a significant step forward for GeoNode UX. Thank you
Dimitris!
Patrick
On Sep 19, 2017 8:23 AM, "Francesco Bartoli" <a class="moz-txt-link-rfc2396E" href="mailto:xbartolone@gmail.com"><xbartolone@gmail.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Great contribution Dimitri! +1 in the code base
Sent from Nylas Mail
<a class="moz-txt-link-rfc2396E" href="https://n1.nylas.com/link/72e0e9e7634d6c6f2a502dc7068f5361d905ee3269feda10a8072c3c9d4d1f86/0?redirect=https%3A%2F%2Fnylas.com%3Fref%3Dn1&recipient=geonode-devel%40lists.osgeo.org"><https://n1.nylas.com/link/72e0e9e7634d6c6f2a502dc7068f5361d905ee3269feda10a8072c3c9d4d1f86/0?redirect=https%3A%2F%2Fnylas.com%3Fref%3Dn1&recipient=geonode-devel%40lists.osgeo.org></a>,
the best free email app for work
On set 19 2017, at 1:04 pm, Simone Dalmasso <a class="moz-txt-link-rfc2396E" href="mailto:simone.dalmasso@gmail.com"><simone.dalmasso@gmail.com></a>
wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi Dimitris,
I would definitely see this contribution as part of the core codebase
rather that having it as contrib optional app. Therefore I'm +1 in keeping
the js into layer_detail.html, while for css you could add it to the
base.less (that then you can compile minified into base.css).
If you have tests, the better but being mostly js, as I suppose, it's ok
without them as well as we don't have testing facilities in place for js.
While for the doc, it is in a dedicated folder into the main repo
<a class="moz-txt-link-freetext" href="https://github.com/GeoNode/geonode/tree/master/docs">https://github.com/GeoNode/geonode/tree/master/docs</a>
<a class="moz-txt-link-rfc2396E" href="https://github.com/GeoNode/geonode/tree/master/docs?recipient=geonode-devel%40lists.osgeo.org"><https://github.com/GeoNode/geonode/tree/master/docs?recipient=geonode-devel%40lists.osgeo.org></a>,
you can find the most convenient place in there.
Thanks a lot for this, very nice and welcome feature.
Let us know if you need further info.
Ciao
2017-09-19 10:33 GMT+02:00 Dimitris Karakostis <
<a class="moz-txt-link-abbreviated" href="mailto:karakostis.dimitris@gmail.com">karakostis.dimitris@gmail.com</a>>:
Hi all,
I have integrated the Layer Filtering functionality in my local master
branch of GeoNode. The functionality gives the possibility to build basic
queries based on the layer's attributes and values and download part of the
layers (in the provided formats) (see screenshot). Currently it works for
local, vector layers.
In the past we have discussed this functionality here:
<a class="moz-txt-link-freetext" href="https://goo.gl/7rTDzF">https://goo.gl/7rTDzF</a>
<a class="moz-txt-link-rfc2396E" href="https://goo.gl/7rTDzF?recipient=geonode-devel%40lists.osgeo.org"><https://goo.gl/7rTDzF?recipient=geonode-devel%40lists.osgeo.org></a>
As this is my first contribution to the GeoNode community, I want to be
sure that the commit complies to best practices in terms of documentation,
potential tests and code.
Currently I have included CSS and javascript code in the
layer_detail.html. Should I move these snippets of code in external files?
How and where do I update the documentation?
Any advice on the above would be greatly appreciated.
Thanks.
Dimitris
_______________________________________________
geonode-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:geonode-devel@lists.osgeo.org">geonode-devel@lists.osgeo.org</a>
<a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/geonode-devel">https://lists.osgeo.org/mailman/listinfo/geonode-devel</a>
<a class="moz-txt-link-rfc2396E" href="https://lists.osgeo.org/mailman/listinfo/geonode-devel?recipient=geonode-devel%40lists.osgeo.org"><https://lists.osgeo.org/mailman/listinfo/geonode-devel?recipient=geonode-devel%40lists.osgeo.org></a>
--
Simone
_______________________________________________
geonode-devel mailing <a class="moz-txt-link-abbreviated" href="mailto:listgeonode-devel@lists.osgeo.orghttps://lists.osgeo.org/mailman/listinfo/geonode-devel">listgeonode-devel@lists.osgeo.orghttps://lists.osgeo.org/mailman/listinfo/geonode-devel</a>
</pre>
</blockquote>
<pre wrap="">_______________________________________________
geonode-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:geonode-devel@lists.osgeo.org">geonode-devel@lists.osgeo.org</a>
<a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/geonode-devel">https://lists.osgeo.org/mailman/listinfo/geonode-devel</a>
</pre>
</blockquote>
<pre wrap="">
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
geonode-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:geonode-devel@lists.osgeo.org">geonode-devel@lists.osgeo.org</a>
<a class="moz-txt-link-freetext" href="https://lists.osgeo.org/mailman/listinfo/geonode-devel">https://lists.osgeo.org/mailman/listinfo/geonode-devel</a>
</pre>
</blockquote>
<p><br>
</p>
<pre class="moz-signature" cols="72">--
Angelos Tzotsos, PhD
Charter Member
Open Source Geospatial Foundation
<a class="moz-txt-link-freetext" href="http://users.ntua.gr/tzotsos">http://users.ntua.gr/tzotsos</a></pre>
</body>
</html>