[Geoprisma-dev] WFS Proxy

[Etienne Dube]

Hi Alexandre,


On 18/03/2011 4:01 PM, Alexandre Dube wrote:
> Hi Etienne,
>
>
>
> On 11-03-18 03:49 PM, Etienne Dube wrote:
>> Hey guys,
>>
>> The WFS Proxy works and is ready to be committed. For the moment only 
>> the GetFeature operation is supported, using an XML POST request type 
>> (that's what OpenLayers uses by default).
>>
>> I had to do a slight change in the API of the Proxy class, namely 
>> making Proxy::getLayers() non-static (it's now an instance method 
>> which uses member variables) ; WFS queries are way more complex than 
>> any other ones in existing proxies, and I added members in the 
>> WFSProxy class to keep track of the kind of request that is being 
>> processed and the XML body of the POST request. WFSProxy::getLayers() 
>> uses this information (namely to parse the XML request), hence the 
>> change in the API. I applied the change to every subclass of Proxy 
>> too, and made sure that every call to getLayers() is done using an 
>> object instance instead of calling a static class method.
>
> That's fine.


I also modified the new WPSProxy class to comply with this API change.


>
>
>>
>> Note that I didn't bother to add support for WFS layers in the old 
>> Map widget ; it's only supported in Layer widgets used along a 
>> MapPanel. Should we do it also for the Map widget??
>
> I'd say no need to.
>
>
>>
>> This change shouldn't break anything, but if you want to review the 
>> new code before I commit it, just ask and I'll prepare a patch.
>> Otherwise, is it okay for you all if I commit the code?
>
> Run a phpcs to the files you changed then you can commit.  Simply link 
> the revision in your ticket you created.
> http://trac.osgeo.org/geoprisma/ticket/201
>
>

phpcs threw a bunch of errors for almost every source file in my local 
copy (not only the new WFS proxy files). Are there any settings that I 
have to use with phpcs so that it checks the coding style according to 
what we already use?

Anyway, I made sure that the coding style in the new files is similar to 
existing .php files, and went ahead with the commit.

Thanks for your feedback!


Etienne




>> I still need to clean up the sample (we will need a WFS service on 
>> the geoprisma.org server for the sample to work) and implement other 
>> operations (GetCapabilities, DescribeFeatureType and transactional 
>> operations), but at least we'll have a first working implementation 
>> in the trunk.
>
> Commit often, release early.  That's fine.  Just put notices as you 
> commit in the ticket.
>
> Regards,
>


-- 
Etienne Dubé
Developer

Boréal Informations Stratégiques
101, Du Moulin, bureau 202-A
Magog (Québec)
J1X 4A1
Canada

Tel. :  514.313.5951 #1131
Email: etienne.dube at boreal-is.com