[geos-commits] r2364 - trunk/source/algorithm

svn_geos at osgeo.org svn_geos at osgeo.org
Tue Apr 14 20:27:49 EDT 2009


Author: strk
Date: 2009-04-14 20:27:49 -0400 (Tue, 14 Apr 2009)
New Revision: 2364

Modified:
   trunk/source/algorithm/HCoordinate.cpp
Log:
Explain why unrolled computation is turned off, and keep it off

Modified: trunk/source/algorithm/HCoordinate.cpp
===================================================================
--- trunk/source/algorithm/HCoordinate.cpp	2009-04-15 00:14:05 UTC (rev 2363)
+++ trunk/source/algorithm/HCoordinate.cpp	2009-04-15 00:27:49 UTC (rev 2364)
@@ -57,7 +57,12 @@
 	     << " q2: " << q2 << endl;
 #endif
 
-#if 0 // TODO: fix this, results in a testcase failure!
+#if 0 // NOTE: unrolled computation is intentionally turned off
+      //       as it makes the algorithm less stable numerically
+      //       In particular the first case in TestBufferMitredJoin.xml
+      //       would fail with unrolled computation on and no input
+      //       simplification in operation/buffer/OffsetCurveBuilder.cpp
+
 	// unrolled computation
 
 	double px = p1.y - p2.y;



More information about the geos-commits mailing list