[geos-commits] [SCM] GEOS branch svn-3.6 updated. 1ec3a55168d52997d57469bd6be683cfa69cd375

git at osgeo.org git at osgeo.org
Wed Sep 18 09:42:40 PDT 2019


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GEOS".

The branch, svn-3.6 has been updated
       via  1ec3a55168d52997d57469bd6be683cfa69cd375 (commit)
       via  db00eaf430de977449a238c9729e71e616f239e6 (commit)
      from  9362bf25c5ab5508aa70287a6c557ea5d0596beb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1ec3a55168d52997d57469bd6be683cfa69cd375
Merge: db00eaf 9362bf2
Author: Paul Ramsey <pramsey at cleverelephant.ca>
Date:   Wed Sep 18 09:42:37 2019 -0700

    Merge branch 'svn-3.6' of https://git.osgeo.org/gogs/geos/geos into svn-3.6


commit db00eaf430de977449a238c9729e71e616f239e6
Author: Paul Ramsey <pramsey at cleverelephant.ca>
Date:   Wed Sep 18 09:42:17 2019 -0700

     Allocate default geometryfactory on the stack
    Makes valgrind happier.
    References #714
    Thanks Sandro Mani

diff --git a/NEWS b/NEWS
index 6ec1c06..aeff469 100644
--- a/NEWS
+++ b/NEWS
@@ -12,7 +12,7 @@ Changes in 3.6.4
   - Static library does not contain C API (#878)
   - Prevent crash when querying empty STRtree (#730)
   - Overlay performance improvement (#986, Paul Ramsey)
-
+  - Allocate default geometryfactory on the stack (#714)
 
 Changes in 3.6.3
 2018-08-06
diff --git a/src/geom/GeometryFactory.cpp b/src/geom/GeometryFactory.cpp
index 0c8abfc..ac6e66e 100644
--- a/src/geom/GeometryFactory.cpp
+++ b/src/geom/GeometryFactory.cpp
@@ -783,8 +783,8 @@ GeometryFactory::destroyGeometry(Geometry *g) const
 const GeometryFactory*
 GeometryFactory::getDefaultInstance() 
 {
-	static GeometryFactory* defInstance = new GeometryFactory();
-	return defInstance;
+	static GeometryFactory defInstance;
+	return &defInstance;
 }
 
 /*private*/

-----------------------------------------------------------------------

Summary of changes:
 NEWS                         | 2 +-
 src/geom/GeometryFactory.cpp | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
GEOS


More information about the geos-commits mailing list