[geos-commits] [SCM] GEOS branch 3.11 updated. 610e2a764ae6c713a2d39e69556fb809b8c2a8ef

git at osgeo.org git at osgeo.org
Wed Feb 5 14:46:58 PST 2025


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GEOS".

The branch, 3.11 has been updated
       via  610e2a764ae6c713a2d39e69556fb809b8c2a8ef (commit)
      from  ee4d9363d03f62077363d6cfb24a257feec657d9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 610e2a764ae6c713a2d39e69556fb809b8c2a8ef
Author: Martin Davis <mtnclimb at gmail.com>
Date:   Wed Feb 5 14:46:37 2025 -0800

    Fix BufferOp to increase length of segments removed by heuristic

diff --git a/NEWS.md b/NEWS.md
index 9ee46214e..f724ee5e8 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -10,6 +10,7 @@
   - GEOSConcaveHullOfPolygons, avoid crash on zero-area input (GH-1071, Dan Baston)
   - MinimumClearance, avoid crash on NaN inputs (GH-1079, Dan Baston)
   - Fix TopologyPreservingSimplifier/TaggedLineString to avoid jumping components (JTS-1096, Martin Davis)
+  - Fix BufferOp to increase length of segments removed by heuristic (GH-1200, Martin Davis)
   - Add ring buffer hole removal heuristic (GH-1233, Martin Davis)
 
 ## Changes in 3.11.4
diff --git a/src/operation/buffer/OffsetSegmentGenerator.cpp b/src/operation/buffer/OffsetSegmentGenerator.cpp
index 579a30248..3981c5745 100644
--- a/src/operation/buffer/OffsetSegmentGenerator.cpp
+++ b/src/operation/buffer/OffsetSegmentGenerator.cpp
@@ -49,7 +49,7 @@ namespace operation { // geos.operation
 namespace buffer { // geos.operation.buffer
 
 /*private data*/
-const double OffsetSegmentGenerator::CURVE_VERTEX_SNAP_DISTANCE_FACTOR = 1.0E-6;
+const double OffsetSegmentGenerator::CURVE_VERTEX_SNAP_DISTANCE_FACTOR = 1.0E-4;
 const double OffsetSegmentGenerator::OFFSET_SEGMENT_SEPARATION_FACTOR = 1.0E-3;
 const double OffsetSegmentGenerator::INSIDE_TURN_VERTEX_SNAP_DISTANCE_FACTOR = 1.0E-3;
 const double OffsetSegmentGenerator::SIMPLIFY_FACTOR = 100.0;
diff --git a/tests/unit/operation/buffer/BufferOpTest.cpp b/tests/unit/operation/buffer/BufferOpTest.cpp
index d51039b94..387b91eb6 100644
--- a/tests/unit/operation/buffer/BufferOpTest.cpp
+++ b/tests/unit/operation/buffer/BufferOpTest.cpp
@@ -600,7 +600,6 @@ void object::test<23>
 }
 */
 
-/* MD - not fixed in this ver
 // Test that hole is not removed
 // See https://github.com/libgeos/geos/issues/1125
 template<>
@@ -621,7 +620,6 @@ void object::test<24>
     ensure_equals(result->getNumGeometries(), 1u);
     ensure_equals( (dynamic_cast<const Polygon*>( result.get() )->getNumInteriorRing()), 3u);
 }
-*/
 
 // testRingHoleEroded
 // See https://github.com/libgeos/geos/issues/1223

-----------------------------------------------------------------------

Summary of changes:
 NEWS.md                                         | 1 +
 src/operation/buffer/OffsetSegmentGenerator.cpp | 2 +-
 tests/unit/operation/buffer/BufferOpTest.cpp    | 2 --
 3 files changed, 2 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
GEOS


More information about the geos-commits mailing list