[geos-commits] [SCM] GEOS branch 3.12 updated. d65efba97eb6f1af578b14cf751566bdc74dee7d

[git at osgeo.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GEOS".

The branch, 3.12 has been updated
       via  d65efba97eb6f1af578b14cf751566bdc74dee7d (commit)
       via  15102e9960b30c430120d455d5db7f364ed10b42 (commit)
       via  52b0bb7d3b6be611a41ccc503d6ba93353618166 (commit)
      from  010e3f977adadd3390d5e4aaa02720848a4fd98b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d65efba97eb6f1af578b14cf751566bdc74dee7d
Author: Paul Ramsey <pramsey at cleverelephant.ca>
Date:   Mon Jan 13 12:13:47 2025 -0800

    News entry for GH-1225

diff --git a/NEWS.md b/NEWS.md
index 5bcb22618..4829fbd6f 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -16,6 +16,7 @@
   - Fix TopologyPreservingSimplifier/TaggedLineString to avoid jumping components (JTS-1096, Martin Davis)
   - Fix BufferOp to increase length of segments removed by heuristic (GH-1200, Martin Davis)
   - Improve OffsetCurve to handle mitre joins for polygons (Martin Davis)
+  - Fix inscribed circle initialization (GH-1225, Benoit Maurin)
 
 ## Changes in 3.12.2
 2024-06-05

commit 15102e9960b30c430120d455d5db7f364ed10b42
Author: Benoit Maurin <maurinbe at gmail.com>
Date:   Mon Jan 13 19:20:44 2025 +0100

    Fix tests

diff --git a/tests/unit/algorithm/construct/MaximumInscribedCircleTest.cpp b/tests/unit/algorithm/construct/MaximumInscribedCircleTest.cpp
index 7a7add925..faf341a64 100644
--- a/tests/unit/algorithm/construct/MaximumInscribedCircleTest.cpp
+++ b/tests/unit/algorithm/construct/MaximumInscribedCircleTest.cpp
@@ -172,7 +172,7 @@ void object::test<5>
 ()
 {
     checkCircle("POLYGON ((100 100, 200 200, 100 100, 100 100))",
-       0.01, 150, 150, 0 );
+       0.01, 100, 100, 0 );
 }
 
 
@@ -197,7 +197,7 @@ void object::test<7>
 ()
 {
      checkCircle("POLYGON((1 2, 1 2, 1 2, 1 2, 3 2, 1 2))",
-       0.01, 2, 2, 0 );
+       0.01, 1, 2, 0 );
 }
 
 // Exception thrown to avoid infinite loop with infinite envelope

commit 52b0bb7d3b6be611a41ccc503d6ba93353618166
Author: Benoit Maurin <maurinbe at gmail.com>
Date:   Mon Jan 13 17:59:31 2025 +0100

    Fix inscribed circle initialization

diff --git a/src/algorithm/construct/MaximumInscribedCircle.cpp b/src/algorithm/construct/MaximumInscribedCircle.cpp
index c3a471078..89c910d3b 100644
--- a/src/algorithm/construct/MaximumInscribedCircle.cpp
+++ b/src/algorithm/construct/MaximumInscribedCircle.cpp
@@ -164,8 +164,8 @@ MaximumInscribedCircle::distanceToBoundary(double x, double y)
 MaximumInscribedCircle::Cell
 MaximumInscribedCircle::createInteriorPointCell(const Geometry* geom)
 {
-    Coordinate c;
     std::unique_ptr<Point> p = geom->getInteriorPoint();
+    Coordinate c(p->getX(), p->getY());
     Cell cell(p->getX(), p->getY(), 0, distanceToBoundary(c));
     return cell;
 }

-----------------------------------------------------------------------

Summary of changes:
 NEWS.md                                                       | 1 +
 src/algorithm/construct/MaximumInscribedCircle.cpp            | 2 +-
 tests/unit/algorithm/construct/MaximumInscribedCircleTest.cpp | 4 ++--
 3 files changed, 4 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
GEOS