[geos-devel] GEOS libraries

[Martin Davis]

Sounds fairly harmless to me to integrate the changes - except for the ones that comment out swads of the original source code, of course.

The idea of splitting out the tests into a separate dir is good.

Since there has been no dissension I assume the concept of putting everything in one library is a good one also?  I can't imagine why we *wouldn't* do that, especially given the knarly interdependencies.

Martin Davis, Senior Technical Specialist
Vivid Solutions Inc.
Suite #1A-2328 Government Street   Victoria, B.C.   V8T 5G5
Phone: (250) 385 6040    Fax: (250) 385 6046
EMail: mbdavis at vividsolutions.com  Web: www.vividsolutions.com


> -----Original Message-----
> From: Paul Ramsey [mailto:pramsey at refractions.net]
> Sent: Friday, August 30, 2002 11:00 AM
> To: geos-devel at geos.refractions.net
> Subject: Re: [geos-devel] GEOS libraries
> 
> 
> I have a CVS sandbox with Normans changes integrated ready to 
> commit. I 
> have not integrated his changes to the actual code, which 
> commented out 
> alot of code which failed to compile under UNIX. I assume 
> we'll fix that 
> in a different pass.
> 
> Is there any reason I should not commit up these changes?
> They do two things: (a) add a bunch of Makefile.am files to the 
> directory structure (no harm) and (b) move all the testing 
> files out of 
> the /source directory and into /source/test
> 
> Speak now or forever hold your peace...
> P.
> 
> Yury A. Bychkov wrote:
> > Hi everyone,
> > 
> > Me and Martin have just finished discussing it and here is 
> what we think:
> > 
> > 
> >>I have a quick question
> >>about the library structure. The most natural source tree 
> configuration
> >>for automake is one library per directory - based on this I would
> >>produce three libraries, libgsgeo (from source in 
> source/geom), libgsgrp
> >>(source/graph) and libgsio (source/io). I assume the code in
> >>subdirectories of these (source/io/markup, source/graph/index) would
> >>link into the corresponding upper-level library. Everyone 
> ok with this
> >>(names and arrangements)?
> > 
> > There are way to many rather complex interdependencies for 
> it to work (even
> > 'graph/index' is called from outside of 'graph'). It seems 
> to us that everything
> > should be put in one library.
> > 
> > 
> > 
> >>Also, is the code in util/ needed into any of the libs? If 
> so, which one?
> > 
> > 'util' contains Assert class that is used almost everywhere.
> > 
> > 
> > 
> >>Yury - do you want me to fix the trivial quirks about the 
> code (like the
> >>need for including stdio.h for sprintf)?
> > 
> > I'd prefer if you'll just send me an email and tell me what 
> you want me to
> > change.
> > 
> > Yury
> > 
> > 
> > 
> > _______________________________________________
> > geos-devel mailing list
> > geos-devel at geos.refractions.net
> > http://geos.refractions.net/mailman/listinfo/geos-devel
> > 
> 
> 
> -- 
>        __
>       /
>       | Paul Ramsey
>       | Refractions Research
>       | Email: pramsey at refractions.net
>       | Phone: (250) 885-0632
>       \_
> 
> 
> _______________________________________________
> geos-devel mailing list
> geos-devel at geos.refractions.net
> http://geos.refractions.net/mailman/listinfo/geos-devel
>