[geos-devel] WKTReader - ambiguous comments

strk at refractions.net strk at refractions.net
Thu Mar 30 04:27:59 EST 2006


On Thu, Mar 30, 2006 at 08:21:06AM +0200, Mateusz Å?oskot wrote:
> Hi,
> 
> The WKTReader constructor:
> WKTReader(const geom::GeometryFactory *gf);
> takes geometry factory by const pointer and
> as I see it creates internal copy of object pointed by gf pointer:
> 
> // WKTReader.inl file
> 
> WKTReader::WKTReader(const geom::GeometryFactory *gf)
> : geometryFactory(gf)

No copy here, geometryFactory is a pointer, and gets assigned
the given pointer.
One of zillion cases where shared_ptr<> would be more appropriate.

--strk;



More information about the geos-devel mailing list