[geos-devel] C-API Header diversion

strk at refractions.net strk at refractions.net
Thu Oct 26 07:11:28 EDT 2006

On Thu, Oct 26, 2006 at 01:05:19PM +0200, Markus Schaber wrote:
> Hi,
> In order to automatically capture diversions between capi/geos_c.cpp and
> capi/geos_c.h, I applied the attached patch to geos.
> Apart from being an ugly hack that I don't want to see applied
> permanently, it tells us that most remaining differences seem to be
> signed vs. unsigned char, and const declaration.
> Should those be fixed? And can we come up with a better scheme to
> automatically catch diversions of those files?

I'd rather see this applied permanently, unless you see any
drawback (I assume you also get rid of all prototypes in the
.cpp file).

I think we can fix const vs. unconst and signed vs. unsigned,
witout fear of breaks. IIRC the problem with signed vs. unsigned
was with function returning -1 on exception. Those would force
callers to cast to signed for checking...


More information about the geos-devel mailing list