[geos-devel] C API Union Looks Wrong - Ignores Geometry::Union Shortcuts

[Charlie Savage]

I think the CAPI is incorrectly performing the union operation.

Here is Geometry::Union:

Geometry*
Geometry::Union(const Geometry *other) const
	//throw(TopologyException *, IllegalArgumentException *)
{
	checkNotGeometryCollection(this);
	checkNotGeometryCollection(other);

	Geometry *out = NULL;

         <bunch of shortcircuit stuff>

	return OverlayOp::overlayOp(this, other, OverlayOp::opUNION);
}

And here is the CAPI call:

GEOSUnion(const Geometry *g1, const Geometry *g2)
{
   GeomAutoPtr g3 = BinaryOp(g1, g2, overlayOp(OverlayOp::opUNION));
   ...
}

Notice the CAPI entirely skips Geometry::Union and therefore doesn't use 
any of the shortcuts.  Why is this?  Shouldn't just be:

g1.union(g2)

Note that all the same issue occurs in various other CAPI exposed calls.

Thanks,

Charlie



-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3237 bytes
Desc: S/MIME Cryptographic Signature
Url : http://lists.osgeo.org/pipermail/geos-devel/attachments/20070907/c4c766ce/smime.bin