[geos-devel] GEOS-3.3.0rc1 released

[Frank Warmerdam]

On 11-05-19 03:53 PM, Sandro Santilli wrote:

> The change in PolygonBuilder.cpp looks suspicious.
> The "found two shells in MinimalEdgeRing" exception was even
> triggered by a recently closed bug.
>
> Could you reverse that and file a ticket explaining why you'd need
> to disable it when building with NDEBUG ?

Strk,

The definition of shellCount was already:

#ifndef NDEBUG
	int shellCount=0;
#endif

It seems clear, in context, that the shellCount related stuff was setup
to be a debug-only build check.  I have no idea why.  All I did was
extend things accordingly.  So I'm not really inclined to back it out,
and file a ticket.  But if you think that the shellCount checks and
corresponding exception should always be evaluated then I would suggest
filing a ticket to that effect and we can remove all the #ifndef NDEBUG
wrappers for shellCount stuff.

Best regards,
-- 
---------------------------------------+--------------------------------------
I set the clouds in motion - turn up   | Frank Warmerdam, warmerdam at pobox.com
light and sound - activate the windows | http://pobox.com/~warmerdam
and watch the world go round - Rush    | Geospatial Programmer for Rent