[geos-devel] Bug in src/noding/snapround/HotPixel.cpp?

Mickael BORNE mickael.borne at ign.fr
Mon Jun 24 08:45:20 PDT 2013


> Hey Mickael, confirmed !
> This clearly shows how the snaprounding code is in need of
> testcases. How did you find out ? Any code we can put under
> testsuite ?


A member of my team (Pierre) works on a SnapRouding based on 
boost::graph and GEOS and he faced the following case :

+---+
+  /
+ / +
+/   \
       \
        \
         +

I'll look for the corresponding test.

>
> --strk;
>
> On Fri, Jun 21, 2013 at 06:29:40PM +0200, Mickael BORNE wrote:
>> Hi geos-devel!
>>
>> Could you confirm and patch the following bug in :
>>
>> void HotPixel::initCorners(const Coordinate& pt)
>>
>>
>> A triangle is represented instead of a square :
>>
>>
>> Index: src/noding/snapround/HotPixel.cpp
>> ===================================================================
>> --- src/noding/snapround/HotPixel.cpp    (révision 3823)
>> +++ src/noding/snapround/HotPixel.cpp    (copie de travail)
>> @@ -83,7 +83,7 @@
>>       corner[0] = Coordinate(maxx, maxy);
>>       corner[1] = Coordinate(minx, maxy);
>>       corner[2] = Coordinate(minx, miny);
>> -    corner[3] = Coordinate(maxx, maxy);
>> +    corner[3] = Coordinate(maxx, miny);
>>   }
>>
> _______________________________________________
> geos-devel mailing list
> geos-devel at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/geos-devel
>



More information about the geos-devel mailing list