[geos-devel] Thread safe error handling

[Sandro Santilli]

On Mon, Sep 09, 2013 at 05:56:39PM +0200, Pepijn Van Eeckhoudt wrote:
> On ma, 2013-09-09 at 16:04 +0200, Sandro Santilli wrote:
> > On Mon, Sep 09, 2013 at 03:44:16PM +0200, Pepijn Van Eeckhoudt wrote:
> > 
> > > You mean https://github.com/libgeos/libgeos.git right? That's what I
> > > cloned from.
> > 
> > Yes, sorry.
> > 
> > > In the version of geos_ts_c.cpp I'm looking at
> > > GEOSContextHandleInternal_t is a typedef for struct
> > > GEOSContextHandleInternal. I can change it to be a class if you like.
> > > 
> > > Are we talking about the same GEOSContextHandleInternal_t?
> > 
> > Yes, same type.
> > 
> > Struct and class are the same in C++.
> > Only difference is in the default access to members being private
> > for class and public for struct.
> 
> I modified the patch as you suggested and submitted it as a pull request
> via github. NOTICE_MESSAGE and ERROR_MESSAGE are now methods on
> GEOSContextHandleInternal_t.
> 
> I didn't change the casing of NOTICE_MESSAGE and ERROR_MESSAGE to keep
> the scope of patch as small as possible.

Appreciated.
Could you also file a ticket on trac with a pointer to the
pull request ?

http://trac.osgeo.org/geos/

You'll need an OSGeo account, if you don't have one already:
http://www.osgeo.org/osgeo_userid/

--strk;