[geos-devel] Extraction of PHP extension into PECL-style package

[J Smith]

G'day list. Just a quick update on the PHP GEOS extension.

- Added in some TSRMLS calls that I noticed were missing.

- Moved the tests from PHPUnit-style tests to .phpt style tests as per
the usual PECL extension layout so that they'd have no dependencies on
PHPUnit. I created a small PHPUnit-like compatibility class so the
tests themselves are pretty much 99% directly copied over with a few
exceptions for dealing with some PHPUnit-specific stuff like some
comment annotations that determine test behaviour and the like. The
tests for the most part remain untouched, but are more suited to the
PECL Way of writing test.

- Add the `make check` Makefile target that Sandro was looking for.

That's all for now. I'll see if I can start the PECL process and get
this thing available through those channels.

Cheers

On Fri, Feb 5, 2016 at 3:08 AM, Sandro Santilli <strk at keybit.net> wrote:
> On Thu, Jan 28, 2016 at 10:05:51AM -0500, J Smith wrote:
>> The standard PHP build for extensions comes with a `make test` target,
>> I'll have to check on `make check`. Would `make test` itself work? I
>> think some work could be done to make the tests a bit more
>> PEAR-friendly, but as a start, would `make test` work?
>
> The PHP bindings of GEOS already have a test: test/test.php
> This test used to run on "make check".
> I just want to see those tests run again on "make check",
> but I don't mind if you want to add any other alias to the
> "check" rule and I'm happy if you want to add tests :)
>
> What's important to me is that "make check" runs all tests
> and reports success/failures. Then we can instruct bots
> to run "make check" on every commit.
>
> --strk;
> _______________________________________________
> geos-devel mailing list
> geos-devel at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/geos-devel