[geos-devel] [GEOS] #846: UTF8 BOM in headers ?

[GEOS]

#846: UTF8 BOM in headers ?
------------------------+--------------------------
 Reporter:  landry      |      Owner:  geos-devel@…
     Type:  defect      |     Status:  new
 Priority:  major       |  Milestone:  3.6.3
Component:  Default     |    Version:  3.6.2
 Severity:  Unassigned  |   Keywords:
------------------------+--------------------------
 I have a build failure for 3.6.2 on sparc64 using gcc4.9; see http
 ://build-failures.rhaalovely.net//sparc64/2017-11-12/geo/geos.log for the
 full log, but the interesting part is:

 {{{
 ../../../include/geos/geom/Polygonal.h:1: error: stray '\357' in program
 ../../../include/geos/geom/Polygonal.h:1: error: stray '\273' in program
 ../../../include/geos/geom/Polygonal.h:1: error: stray '\277' in program
 In file included from ../../../include/geos/geom/MultiPolygon.h:29,
                  from IndexedPointInAreaLocator.cpp:19:
 ../../../include/geos/geom/Polygonal.h:1: error: stray '\357' in program
 ../../../include/geos/geom/Polygonal.h:1: error: stray '\273' in program
 ../../../include/geos/geom/Polygonal.h:1: error: stray '\277' in program
 In file included from ../../../include/geos/geom/LineString.h:27,
                  from IndexedPointInAreaLocator.cpp:20:
 ../../../include/geos/geom/Lineal.h:1: error: stray '\357' in program
 ../../../include/geos/geom/Lineal.h:1: error: stray '\273' in program
 ../../../include/geos/geom/Lineal.h:1: error: stray '\277' in program
 In file included from
 ../../../include/geos/util/IllegalArgumentException.h:22,
                  from IndexedPointInAreaLocator.cpp:25:
 ../../../include/geos/util/GEOSException.h:1: error: stray '\357' in
 program
 ../../../include/geos/util/GEOSException.h:1: error: stray '\273' in
 program
 ../../../include/geos/util/GEOSException.h:1: error: stray '\277' in
 program


 $file include/geos/*/*|grep ISO
 include/geos/geom/Lineal.h:                                   ISO-8859
 English text
 include/geos/geom/Polygonal.h:                                ISO-8859
 English text
 include/geos/geom/Puntal.h:                                   ISO-8859
 English text
 include/geos/util/GEOSException.h:                            ISO-8859
 English text
 }}}

 It seems those files start with an utf8 BOM:

 {{{
 $head -1 include/geos/geom/Lineal.h |hexdump
 0000000    bbef    2fbf    2a2a
 $head -1 include/geos/geom/IntersectionMatrix.h |hexdump
 0000000    2a2f    2a2a    2a2a
 }}}

 Pretty sure removing those wrong chars will fix my build.. either way they
 shouldnt be here :)

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/846>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).