[geos-devel] GEOS 3.7.0rc1 release

Regina Obe lr at pcorp.us
Mon Aug 20 21:14:36 PDT 2018


> From: Greg Troxel [mailto:gdt at lexort.com]
> 
>   VERSION_RELEASE=`echo "$VERSION" | sed -E 's/^([0-9]+\.[0-9]+\.[0-
> 9]+)(.*)?$/\1/'`
> 
> GNU sed may be allowing this as an extension, because "*?" doesn't make
> sense, since * is repetition.
> 
> Actually, the whole ? is redundant and can be just dropped, because
> 
>   (.*)?
> 
> matches zero or more occurrences fo any character, and also the empty
> string.  But .* matches the empty string anyway.  So while I can see the
point
> that it leads the reader to think "either some arbitrary string or the
empty
> string", it's just more complicated for no good reason.
> 
> So just drop the ? after the .*
[Regina Obe] 
Come to think of it, I think Sebastian's original didn't have that and I
forgot to take it out.

Anyway I have ticketed

https://trac.osgeo.org/geos/ticket/917

I'll fix later today or tomorrow.  I think it should be fine.

Thanks,
Regina




More information about the geos-devel mailing list