[geos-devel] GEOS 3.7.0rc1 release

Regina Obe lr at pcorp.us
Thu Aug 23 12:10:31 PDT 2018


> Jeff McKenna <jmckenna at gatewaygeomatics.com> writes:
> 
> > That was it, manually copying the missing file from svn or git, into
> > the release package (geos-3.7.0rc1.tar.bz2) allows GEOS to compile
> > with msvc 2017.
> 
> It seems better to adjust the cmake stuff not to expect such a file than to put
> it in the release.
[Regina Obe] 
I was thinking about that but in this case I figured people might be using the tar ball for development and if they should make changes and try to send us a patch, I'd want the patch to follow the standard so we should include the .editorconfig in the tar ball anyway.  

Have ticket here:
https://trac.osgeo.org/geos/ticket/920#ticket


I need to up port to 3.8 but need to fix some things before I do that.
As to why it was explicitly added in CMake (was very intentional), so not going to bother taking it out.

if (MSVC_IDE)
  # Visual Studio 2017 supports .editorconfig, copy it next to generated .sln
  message(STATUS "Copying .editorconfig file to ${PROJECT_BINARY_DIR}")
  file(COPY "${PROJECT_SOURCE_DIR}/.editorconfig"
    DESTINATION "${PROJECT_BINARY_DIR}")
endif()




More information about the geos-devel mailing list