[geos-devel] XML Tests

[Daniel Baston]

I get four test failures on Ubuntu 16.04 if I run the tests the way that
Paul is doing it. Paul's command gives four failures in 70 seconds, while
"make check" reports no failures in 7 seconds. Clearly, "make check" isn't
running all of the tests.

The autotools config relies on hardcoded lists of "SAFE_XMLTESTS" and
"FAILING_XMLTESTS" and only runs the "SAFE_XMLTESTS" as part of "make
check." If my counting is right, there are some test files that are neither
listed in SAFE_XMLTESTS nor FAILING_XMLTESTS and are also not run by the
autotools "make check".

The WIP CMake configuration, like Paul's command, uses globbing to find all
of the xml files, and it also fails.

Dan

On Sat, Nov 10, 2018 at 4:16 AM Sandro Santilli <strk at kbt.io> wrote:

> On Fri, Nov 09, 2018 at 02:39:43PM -0800, Paul Ramsey wrote:
> > Couple notes from the world of the XML tester.
> > I merged Sandro's tinyxml2 change, which seems to work fine.
> > Running *all* the XML tests on OSX
> >
> > ./XMLTester `find . -name "*.xml" | xargs`
> >
> > I find that four of the tests fail. Is this unique to me, or common to
> GEOS
> > on other platforms? It's possible the make check target does not include
> > the problematic tests, I haven't done that piece of set-intersection yet.
> >
> > Speaking of set intersection, the set of tests in JTS differs from the
> set
> > in GEOS, and it's not just missing GEOS-specific tests. In some cases,
> > long-standing tests like TestCentroid.xml has more tests in JTS than in
> > GEOS. So am I right that an outstanding task is to pull the freshest JTS
> > tests into the GEOS suite?
>
> I agree it is good to have a 1:1 matching of JTS tests to GEOS.
> I think our testLeaksBig.xml contains many tests that are otherwise
> found in other JTS tests, if you port more please remove duplicated
> test from that file, which ideally should be gone at the end of
> porting.
>
> All tests pass for me, on Ubuntu 18.04.1 LTS (GNU/Linux)
>
> --strk;
> _______________________________________________
> geos-devel mailing list
> geos-devel at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/geos-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/geos-devel/attachments/20181111/4b431a84/attachment.html>