[geos-devel] JTS equalsTopo()

[Regina Obe]

I'm more leaning on the side of "let sleeping dogs lie."

 

Don't we have so many other things where our GEOS is a bit out of synch with JTS.  E.g. our weird 3Dish support in GEOS.

 

Is equalsTopo / equals() used in that many places to make not changing it really that difficult to port things?  I would think the extra levels like the coordinate array thingy Dan was complaining about are more troubling than this for porting.

 

From: geos-devel [mailto:geos-devel-bounces at lists.osgeo.org] On Behalf Of Paul Ramsey
Sent: Thursday, November 29, 2018 4:42 PM
To: GEOS Development List <geos-devel at lists.osgeo.org>
Subject: [geos-devel] JTS equalsTopo()

 

Hrm... so, it seems at some point there was a large retrofit to flip equals() to equalsTopo(). I assume that's because (if I recall right) equals() has some special meaning/uses in the Java world, and having it with a different meaning made some things (maps, I think?) not work.

 

GEOS never made that flip, not having the same problem. On the one hand, making the flip would potentially make future porting simpler (method names would line up). On the other hand, it could be an error-prone and labour intensive process... what's your feeling?

P

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/geos-devel/attachments/20181129/b7b829b1/attachment.html>