[geos-devel] TABS or SPACES - ALL DEVELOPERS and PSC Vote

Regina Obe lr at pcorp.us
Mon Sep 10 12:50:37 PDT 2018


Okay it appears I'm losing this game.

 

If we end up settling for spaces.  I'd like to request 4 spaces.  Cause with 2 spaces I'm too blind to see the space so it doesn't look indented at all..

 

From: geos-devel [mailto:geos-devel-bounces at lists.osgeo.org] On Behalf Of Kurt Schwehr
Sent: Monday, September 10, 2018 3:39 PM
To: GEOS Development List <geos-devel at lists.osgeo.org>
Subject: Re: [geos-devel] TABS or SPACES - ALL DEVELOPERS and PSC Vote

 

+1 to 2 or 4 spaces via a standard clang-format style

 

I use multiple different editors/ides/code formatters and they all want to treat tabs differently :|

 

On Mon, Sep 10, 2018 at 11:57 AM Heiskanen Mika (FMI) <Mika.Heiskanen at fmi.fi <mailto:Mika.Heiskanen at fmi.fi> > wrote:

Hello,

 

Perhaps you should consider using automatic formatting tools such as clang-format?

Just choose the style which is as close to your current style as possible, and then

make as few changes to your .clang-format file as possible. Automatic tools will

make your life much easier. Sometimes you will want to disable automatic formatting,

and you can do that directly in the source code. You can make your editor automatically

format the code, and you can add a git-hook to automatically format commits.

‚Äč

Mika

 

 


  _____  


From: geos-devel <geos-devel-bounces at lists.osgeo.org <mailto:geos-devel-bounces at lists.osgeo.org> > on behalf of Martin Davis <mtnclimb at gmail.com <mailto:mtnclimb at gmail.com> >
Sent: Monday, September 10, 2018 21:24
To: GEOS Development List
Subject: Re: [geos-devel] TABS or SPACES - ALL DEVELOPERS and PSC Vote 

 

My vote is the same as Vicky's - spaces, with indenting using multiples of 2. 

 

Reasons:

- lots of religious discussion on the interweb about tabs vs spaces, but a quick read seems to indicate that the spaces camp is more popular

- spaces are more deterministic than tabs

- 2 rather than 4 gives more space for code

 

Martin

 

 

On Mon, Sep 10, 2018 at 9:45 AM Regina Obe <lr at pcorp.us <mailto:lr at pcorp.us> > wrote:

As many know the GEOS code base is a mess of different formatting.
Particular with tabs and spaces.
Our .editorconfig is equally messy in the name of compromise.

I'd like to make a Motion starting with GEOS 3.8 to reformat the .cpp, .h,
and .c

I think the other extensions are pretty standard and should stay as they
are.

That said, what would people prefer?

I vote:

TABS


Please all PSC and all developers who commit to GEOS voice an opinion.
We'll count the votes and go with the consensus with each vote counting
equally.
If any non-dev, non-PSC have an opinion, feel free to voice an opinion
keeping note we may not care about your opinion, but might possibly sway
ours :)

Once done - pramsey or cvvergara or strk will do a 1000 pound commit to
update all these files (including the editorconfig)

Thanks,
Regina

_______________________________________________
geos-devel mailing list
geos-devel at lists.osgeo.org <mailto:geos-devel at lists.osgeo.org> 
https://lists.osgeo.org/mailman/listinfo/geos-devel

_______________________________________________
geos-devel mailing list
geos-devel at lists.osgeo.org <mailto:geos-devel at lists.osgeo.org> 
https://lists.osgeo.org/mailman/listinfo/geos-devel




 

-- 

--

http://schwehr.org

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/geos-devel/attachments/20180910/2c2f8fac/attachment.html>


More information about the geos-devel mailing list