[geos-devel] TABS or SPACES - ALL DEVELOPERS and PSC Vote - MOTION PASSED 4 spaces

[Vicky Vergara]

Hi all
4 space indent on C/C++ files is done
https://git.osgeo.org/gitea/geos/geos/pulls/50

The pre-commit hook needs aStyle installed

Regards
Vicky


On Tue, Sep 11, 2018 at 5:54 PM Regina Obe <lr at pcorp.us> wrote:

> Didn't hear any screaming or objections - so proclaiming MOTION PASSED
> Vicky want to go ahead with your change?  Remember one big gorilla commit
> :)
>
> > -----Original Message-----
> > From: Regina Obe [mailto:lr at pcorp.us]
> > Sent: Tuesday, September 11, 2018 1:43 PM
> > To: 'GEOS Development List' <geos-devel at lists.osgeo.org>
> > Subject: RE: [geos-devel] TABS or SPACES - ALL DEVELOPERS and PSC Vote
> >
> > > On 9/11/18 6:44 AM, Sandro Santilli wrote:
> > > > On Mon, Sep 10, 2018 at 01:15:25PM -0700, Paul Ramsey wrote:
> > > >> Same. 2-spaces hurts my little brain.
> > > > I'm happy as long as you give me a recipe to make my editor
> > > > (vim) automatically use what we choose AND `make check` ensures any
> > > > future change stick with what was choosen.
> > > >
> > > > Note I'd like to keep the 80 cols limit on line width which with
> > > > current naming can easily become close-to-impossible with too many
> > > > spaces. This also means if we use tabs we want them to be rendered
> > > > by a determined number of spaces, or it would be impossible to
> > > > determine the 80 cols limit ...
> > > >
> > > > Go Vicky go !
> > >
> >
> > How is this for a  compromise?
> >
> > 1) We got with 4 spaces
> > 2) 120 cols
> > 3) Get strk a new monitor and also rescue him from his cave.
> > 4) Vicky makes the commit since she wanted spaces and sets editor config
> > accordingly.
> >
> > This would apply to files - .h, .cpp, .c, .inl, .in (that are ins for C
> and C++), .vc
> > (should be windows linebreak I believe though not sure it much matters
> these
> > days)
> >
> > Thanks,
> > Regina
> >
>
>
> _______________________________________________
> geos-devel mailing list
> geos-devel at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/geos-devel



-- 

Georepublic UG (haftungsbeschränkt)
Salzmannstraße 44,
81739 München, Germany

Vicky Vergara
Operations Research

eMail: vicky at georepublic.de
Web: https://georepublic.info

Tel: +49 (089) 4161 7698-1
Fax: +49 (089) 4161 7698-9

Commercial register: Amtsgericht München, HRB 181428
CEO: Daniel Kastl
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/geos-devel/attachments/20180923/94cea40e/attachment-0001.html>