[geos-devel] Inlines?

[Sandro Santilli]

On Tue, Aug 11, 2020 at 03:06:00PM -0700, Paul Ramsey wrote:
> Can anyone shed some light on our inlining strategy? It seems really... odd. 
> Like picked at random, in ConvexHull, the following methods are inlined if GEOS_INLINE is on (it is by default).
> 
> ConvexHull::ConvexHull(const geom::Geometry* newGeometry)
> ConvexHull::~ConvexHull()
> ConvexHull::extractCoordinates(const geom::Geometry* geom)
> 
> Now... none of these feel like they are particularly hot path to me. The constructor, destructor, and a private utilty method.
> I ask mostly because there's a lot of this .inl stuff scattered around and it doesn't seem particularly helpful.
> If there's some history I'd be intrigued to know.

I can't remember why those things ended up in .inl.
I guess destructors were there to try at debugging some issues
with virtual tables not being correct when destructors were inlined
(so to turn inlining off)

--strk;