[geos-devel] [GEOS] #1078: [C API] GEOSCoordSeq_setOrdinate no longer returns error code

[GEOS]

#1078: [C API] GEOSCoordSeq_setOrdinate no longer returns error code
--------------------------------+--------------------------
 Reporter:  jorisvandenbossche  |      Owner:  geos-devel@…
     Type:  defect              |     Status:  new
 Priority:  major               |  Milestone:  3.9.0
Component:  Default             |    Version:  master
 Severity:  Unassigned          |   Keywords:
--------------------------------+--------------------------
 When trying to set an ordinate for a non-existing dimension, the C
 function no longer returns the correct error return value.

 See https://github.com/pygeos/pygeos/issues/233#issuecomment-723860368 for
 context

 This seems to stem from a small mistake in the refactor in
 https://github.com/libgeos/geos/commit/8e29f768e6d8597a5568acd628712583506f9928,
 which accidentally changed the error return value for
 `GEOSCoordSeq_setOrdinate_r` from 0 to 1, so we no longer catch the error.
 I further checked the rest of the file, but I think this is the only case
 of a wrong return code.

-- 
Ticket URL: <https://trac.osgeo.org/geos/ticket/1078>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).