[geos-devel] MSVC Unit Failure

[Paul Ramsey]

I looked into the git log for TopologyPreservingSimplifierTest.cpp and found this:

commit 7014e2b6509709f70dc08ca3b4b4d843d3df2a71
Author: Daniel Baston <dbaston at gmail.com>
Date:   Sat Dec 22 20:49:22 2018 -0500

    Change std::map to std::unordered_map in TopologyPreservingSimplifier

If I change the unordered_map back to a map... I get the exact same unit test failure on my MacOS machine. I've pushed a branch to see if it now succeeds under MSVC.

P


> On Nov 30, 2020, at 8:31 PM, Mike Taves <mwtoews at gmail.com> wrote:
> 
> On Sat, 28 Nov 2020 at 17:59, Paul Ramsey <pramsey at cleverelephant.ca> wrote:
>> 
>> The actual build logs you can see here
>> 
>> https://dev.azure.com/libgeos/geos/_build/results?buildId=772&view=logs&jobId=305851a9-a7bb-55db-0042-7e2b6f48aa1c&j=2bd7b19d-6351-5e7f-8417-63f327ab45bc
> 
> While I don't know how to fix the issue, I've recompiled the issue
> with tests\unit\simplify\TopologyPreservingSimplifierTest.cpp to show
> the expected/result info:
> 
> D:\src\GEOS\geos-git\build>ctest -C Release -R
> unit-simplify-TopologyPreservingSimplifier -V
> UpdateCTestConfiguration  from :D:/src/GEOS/geos-git/build/DartConfiguration.tcl
> Parse Config file:D:/src/GEOS/geos-git/build/DartConfiguration.tcl
> UpdateCTestConfiguration  from :D:/src/GEOS/geos-git/build/DartConfiguration.tcl
> Parse Config file:D:/src/GEOS/geos-git/build/DartConfiguration.tcl
> Test project D:/src/GEOS/geos-git/build
> Constructing a list of tests
> Done constructing a list of tests
> Updating test list for fixtures
> Added 0 tests to meet fixture requirements
> Checking test dependency graph...
> Checking test dependency graph end
> test 198
>    Start 198: unit-simplify-TopologyPreservingSimplifier
> 
> 198: Test command: D:\src\GEOS\geos-git\build\bin\test_geos_unit.exe
> "geos::simplify::TopologyPreservingSimplifier"
> 198: Test timeout computed to be: 1500
> 198: ===============================
> 198:   GEOS Test Suite Application
> 198: ===============================
> 198:
> 198: geos::simplify::TopologyPreservingSimplifier:
> ............expected
> 0105000000020000000102000000020000000000000000000000000000000000000000000000000059400000000000000000010200000003000000000000000000000000000000000000000000000000004940000000000000F03F00000000000059400000000000000000
> 198: result 01050000000200000001020000000200000000000000000000000000000000000000000000000000594000000000000000000102000000020000000000000000000000000000000000000000000000000059400000000000000000
> 198: [14=F]..
> 198:
> 198: ---> group: geos::simplify::TopologyPreservingSimplifier, test: test<14>
> 198:      problem: assertion failed
> 198:      failed assertion: `number of points do not match: expected
> `4` actual `5``
> 198:
> 198: tests summary: failures:1 ok:14
> 1/1 Test #198: unit-simplify-TopologyPreservingSimplifier ...***Failed
>   0.03 sec
> 
> 0% tests passed, 1 tests failed out of 1
> 
> Total Test time (real) =   0.07 sec
> 
> The following tests FAILED:
>        198 - unit-simplify-TopologyPreservingSimplifier (Failed)
> Errors while running CTest
> 
> D:\src\GEOS\geos-git\build>ctest -C Release -R
> unit-simplify-TopologyPreservingSimplifier
> Test project D:/src/GEOS/geos-git/build
>    Start 198: unit-simplify-TopologyPreservingSimplifier
> 1/1 Test #198: unit-simplify-TopologyPreservingSimplifier ...   Passed
>   0.04 sec
> 
> 100% tests passed, 0 tests failed out of 1
> 
> Total Test time (real) =   0.15 sec
> 
> ----
> This test takes input:
> MULTILINESTRING((0 0, 50 0, 70 0, 80 0, 100 0), (0 0, 50 1, 60 1, 100 0))
> 
> And performs simplify with tolerance 10.0, and expects:
> MULTILINESTRING ((0 0, 100 0), (0 0, 50 1, 100 0))
> 
> But for whatever reason, gets:
> MULTILINESTRING ((0 0, 100 0), (0 0, 100 0))
> _______________________________________________
> geos-devel mailing list
> geos-devel at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/geos-devel