[geos-devel] cmake => 3.15?

[Regina Obe]

FWIW Debian Buster I think ships with cmake 3.13 and it’s not that old.  Old but not that old.

 

-1  to increase the cmake version until the pressing reason can be better explained or there are more pressing reasons.

 

As I recall I think Amazon had to upgrade their CMake to build the latest GEOS.

 

Note Debian Buster ships with 3.13 (which is old but not that old).

I also just approved this run of this pull request, and it broke some of our bots like the Ubuntu 20.04, which is kind of in the same boat as Debian Buster, old but not that old. Okay maybe in year when it’s time to release we can consider it ancient.

 

What I am curious to understand is why our VS windows 2022 build running cmake 3.26.4  https://github.com/libgeos/geos/actions/runs/5446890161/jobs/9908248625

 

Seems to be doing just fine without this patch am I missing something here?  What is different about this pull request error. 

What version of VS is this using?

 

Thanks,

Regina

 

 

 

 

From: geos-devel [mailto:geos-devel-bounces at lists.osgeo.org] On Behalf Of Daniel Baston
Sent: Monday, July 3, 2023 5:13 PM
To: GEOS Development List <geos-devel at lists.osgeo.org>
Subject: Re: [geos-devel] cmake => 3.15?

 

I don't see a problem with requiring 3.15, but the issue isn't very clear to me. Is our CMake configuration using some feature of 3.15 while declaring that we only require 3.13?

 

Dan

 

On Mon, Jul 3, 2023 at 3:56 PM Paul Ramsey <pramsey at cleverelephant.ca <mailto:pramsey at cleverelephant.ca> > wrote:

For this small fix with MSVC noise...

https://github.com/libgeos/geos/pull/936

It's still quite an old release, my dev env sits at 3.24 for example.

P
_______________________________________________
geos-devel mailing list
geos-devel at lists.osgeo.org <mailto:geos-devel at lists.osgeo.org> 
https://lists.osgeo.org/mailman/listinfo/geos-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/geos-devel/attachments/20230703/37943383/attachment.htm>