[GRASS-SVN] r58931 - grass/trunk/lib/python/pygrass/modules/interface

svn_grass at osgeo.org svn_grass at osgeo.org
Fri Feb 7 03:52:10 PST 2014


Author: zarch
Date: 2014-02-07 03:52:09 -0800 (Fri, 07 Feb 2014)
New Revision: 58931

Modified:
   grass/trunk/lib/python/pygrass/modules/interface/module.py
Log:
Revert fix for Popen on win platforms

Modified: grass/trunk/lib/python/pygrass/modules/interface/module.py
===================================================================
--- grass/trunk/lib/python/pygrass/modules/interface/module.py	2014-02-07 10:58:02 UTC (rev 58930)
+++ grass/trunk/lib/python/pygrass/modules/interface/module.py	2014-02-07 11:52:09 UTC (rev 58931)
@@ -53,7 +53,6 @@
 from itertools import izip_longest
 from xml.etree.ElementTree import fromstring
 import time
-import sys
 
 
 from grass.pygrass.errors import GrassError, ParameterError
@@ -242,8 +241,7 @@
         try:
             # call the command with --interface-description
             get_cmd_xml = subprocess.Popen([cmd, "--interface-description"],
-                                           stdout=subprocess.PIPE,
-                                           shell=(sys.platform == "win32"))
+                                           stdout=subprocess.PIPE)
         except OSError as e:
             print("OSError error({0}): {1}".format(e.errno, e.strerror))
             str_err = "Error running: `%s --interface-description`."
@@ -470,8 +468,7 @@
                                       stdin=self.stdin_,
                                       stdout=self.stdout_,
                                       stderr=self.stderr_,
-                                      env=self.env_,
-                                      shell=(sys.platform == "win32"))
+                                      env=self.env_)
         if self.finish_:
             stdout, stderr = self.popen.communicate(input=self.stdin)
             self.outputs['stdout'].value = stdout if stdout else ''



More information about the grass-commit mailing list