[GRASS-git] [OSGeo/grass] ecc150: wxGUI/forms: Add giface to standalone forms and fi...

[Vaclav Petras]

  Branch: refs/heads/master
  Home:   https://github.com/OSGeo/grass
  Commit: ecc150f8de351b0efc986a7e48dd22923026afaa
      https://github.com/OSGeo/grass/commit/ecc150f8de351b0efc986a7e48dd22923026afaa
  Author: Vaclav Petras <wenzeslaus at gmail.com>
  Date:   2020-09-13 (Sun, 13 Sep 2020)

  Changed paths:
    M gui/wxpython/core/giface.py
    M gui/wxpython/gui_core/forms.py

  Log Message:
  -----------
  wxGUI/forms: Add giface to standalone forms and fix history in giface (#971)

The standalone forms were not using giface, None was passed instead which caused some parts relying on giface
to be there to fail, specifically, the disabled prompt since 2d24a42cd4b6c66ab81348aa61240e784df39032 (#930).
The prompt is not used in forms, but it is not decoupled from GConsoleWindow, so disabling it, only hides it.

This required to correctly handle implementation of StandaloneGrassInterface::UpdateCmdHistory()
from 22597e67585d787c073fa6e650c9b31e3b87203c which was not
called previously because the code relied on giface not being there in the standalone case instead of dealing
with the implementation differences through the interface. Now the StandaloneGrassInterface implements this
function as no-op since there is nothing to do here. No interactive prompt to update.

The giface function UpdateCmdHistory() was not previously not defined in terms of what it does.
This is now fixed and the new implementation in StandaloneGrassInterface makes sense in light of this definition
(which is based on the implemenation of this method in lmgr).

The function was missing from the abstract interface class which served so far mainly as the general interface documentation.
This is now fixed and StandaloneGrassInterface now newly inherits from this class. The inheritance is optional,
but here it can provide useful default implementations for the functions which are not supported by (and should not with)
the StandaloneGrassInterface instances.

This fixes the standalone forms not starting (from command line) after 2d24a42cd4b6c66ab81348aa61240e784df39032.