[GRASS-git] [OSGeo/grass] 0b7f17: r.geomorphon: fix landform category names (#1421)

[Denis Ovsienko]

  Branch: refs/heads/master
  Home:   https://github.com/OSGeo/grass
  Commit: 0b7f1750f5dbac7194f175b9f60dcbae77bb1017
      https://github.com/OSGeo/grass/commit/0b7f1750f5dbac7194f175b9f60dcbae77bb1017
  Author: Denis Ovsienko <denis at ovsienko.info>
  Date:   2021-06-03 (Thu, 03 Jun 2021)

  Changed paths:
    M raster/r.geomorphon/local_proto.h
    M raster/r.geomorphon/main.c
    M raster/r.geomorphon/memory.c
    M raster/r.geomorphon/r.geomorphon.html
    A raster/r.geomorphon/r_geomorphon_peaks.png
    R raster/r.geomorphon/r_geomorphon_summits.png
    M raster/r.geomorphon/testsuite/test_r_geom.py

  Log Message:
  -----------
  r.geomorphon: fix landform category names (#1421)

* r.geomorphon: fix PK and PT category names

"Peak" and "pit" are the terms consistently used in the code and prose.
"Summit" and "depression" seem to be the terms used before the current
mnemonic codes had settled.

* r.geomorphon: deduplicate landform category code

Move two functions from main.c to memory.c and reduce them to use the
now consistent and more detailed ccolors[] instead of their own lookup
tables.