[GRASS-git] [OSGeo/grass] c38dd6: Fix missing function prototypes (#2727)

Nicklas Larsson noreply at github.com
Sun Jan 22 05:14:56 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/OSGeo/grass
  Commit: c38dd6cc90286c8213ace4b6e002caa9de6a771c
      https://github.com/OSGeo/grass/commit/c38dd6cc90286c8213ace4b6e002caa9de6a771c
  Author: Nicklas Larsson <n_larsson at yahoo.com>
  Date:   2023-01-22 (Sun, 22 Jan 2023)

  Changed paths:
    M db/drivers/dbf/cursor.c
    M db/drivers/dbf/db.c
    M db/drivers/dbf/driver.c
    M db/drivers/dbf/proto.h
    M db/drivers/mysql/cursor.c
    M db/drivers/mysql/driver.c
    M db/drivers/mysql/proto.h
    M db/drivers/odbc/cursor.c
    M db/drivers/odbc/driver.c
    M db/drivers/odbc/proto.h
    M db/drivers/ogr/cursor.c
    M db/drivers/ogr/db.c
    M db/drivers/ogr/driver.c
    M db/drivers/ogr/proto.h
    M db/drivers/postgres/db.c
    M db/drivers/postgres/driver.c
    M db/drivers/sqlite/cursor.c
    M db/drivers/sqlite/driver.c
    M db/drivers/sqlite/proto.h
    M display/d.histogram/bar.h
    M display/d.histogram/pie.h
    M display/d.linegraph/main.c
    M display/d.mon/proto.h
    M display/d.vect/local_proto.h
    M display/d.vect/shape.c
    M general/g.access/set_perms.c
    M general/g.findfile/element.c
    M general/g.findfile/local_proto.h
    M general/g.proj/create.c
    M general/g.proj/local_proto.h
    M general/manage/lister/cell.c
    M general/manage/lister/vector.c
    M imagery/i.cluster/print5.c
    M imagery/i.gensig/eigen.c
    M imagery/i.gensigset/subcluster.c
    M imagery/i.ortho.photo/lib/georef.c
    M imagery/i.ortho.photo/lib/init_info.c
    M imagery/i.segment/iseg.h
    M imagery/i.smap/solve.c
    M include/grass/defs/cluster.h
    M include/grass/defs/gis.h
    M include/grass/defs/nviz.h
    M include/grass/defs/ogsf.h
    M include/grass/defs/raster3d.h
    M include/grass/defs/sqlp.h
    M include/grass/ogsf.h
    M include/grass/raster3d.h
    M include/grass/segment.h
    M include/grass/temporal.h
    M include/grass/vect/dig_externs.h
    M lib/btree/update.c
    M lib/cluster/c_exec.c
    M lib/datetime/change.c
    M lib/datetime/local.c
    M lib/db/dbmi_base/Makefile
    M lib/db/dbmi_base/README
    M lib/db/dbmi_base/dirent.c
    M lib/db/dbmi_base/table.c
    M lib/db/dbmi_base/whoami.c
    M lib/db/dbmi_client/Makefile
    M lib/db/dbmi_driver/Makefile
    M lib/db/dbmi_driver/d_error.c
    M lib/db/dbmi_driver/driver.c
    M lib/db/dbmi_driver/procs.h
    M lib/external/ccmath/ortho.c
    M lib/external/ccmath/ruinv.c
    M lib/external/ccmath/solvru.c
    M lib/external/ccmath/unfl.c
    M lib/external/ccmath/unitary.c
    M lib/gis/basename.c
    M lib/gis/get_window.c
    M lib/gis/ilist.c
    M lib/gis/list.c
    M lib/gis/parser.c
    M lib/gis/plot.c
    M lib/gis/proj3.c
    M lib/gmath/brent.c
    M lib/gpde/N_pde.h
    M lib/gpde/n_les_assemble.c
    M lib/manage/do_list.c
    M lib/manage/sighold.c
    M lib/nviz/exag.c
    M lib/nviz/map_obj.c
    M lib/ogsf/gsd_surf.c
    M lib/ogsf/gsd_wire.c
    M lib/ogsf/gsx.c
    M lib/ogsf/gvl2.c
    M lib/raster/color_look.c
    M lib/raster/get_row.c
    M lib/raster/quant.c
    M lib/raster3d/cache1.c
    M lib/raster3d/cachehash.h
    M lib/raster3d/resample.c
    M lib/raster3d/rle.c
    M lib/rst/qtree/qtree.h
    M lib/temporal/lib/map_list.c
    M lib/vector/Vlib/build.c
    M lib/vector/Vlib/close.c
    M lib/vector/Vlib/open.c
    M lib/vector/Vlib/poly.c
    M lib/vector/Vlib/rewind.c
    M lib/vector/Vlib/write.c
    M lib/vector/dglib/tree.c
    M lib/vector/dglib/tree.h
    M lib/vector/diglib/portable.c
    M lib/vector/diglib/struct_alloc.c
    M lib/vector/diglib/test.c
    M lib/vector/rtree/gammavol.c
    M lib/vector/vedit/render.c
    M ps/ps.map/do_labels.c
    M ps/ps.map/outl_io.c
    M ps/ps.map/ps_outline.c
    M ps/ps.map/r_text.c
    M ps/ps.map/scan_gis.c
    M raster/r.distance/distance.c
    M raster/r.distance/edges.c
    M raster/r.distance/main.c
    M raster/r.distance/report.c
    M raster/r.fill.dir/tinf.c
    M raster/r.fill.dir/tinf.h
    M raster/r.fill.stats/cell_funcs.c
    M raster/r.fill.stats/cell_funcs.h
    M raster/r.fill.stats/main.c
    M raster/r.flow/aspect.h
    M raster/r.flow/io.h
    M raster/r.flow/mem.h
    M raster/r.flow/precomp.h
    M raster/r.geomorphon/geom.c
    M raster/r.geomorphon/local_proto.h
    M raster/r.geomorphon/profile.c
    M raster/r.horizon/main.c
    M raster/r.in.ascii/gethead.c
    M raster/r.in.ascii/main.c
    M raster/r.in.poly/raster.c
    M raster/r.out.mpeg/rom_proto.h
    M raster/r.random.cells/init.c
    M raster/r.random.cells/local_proto.h
    M raster/r.recode/recode.c
    M raster/r.report/global.h
    M raster/r.report/main.c
    M raster/r.sim/simlib/input.c
    M raster/r.sim/simlib/observation_points.c
    M raster/r.sim/simlib/output.c
    M raster/r.sim/simlib/simlib.h
    M raster/r.sim/simlib/waterglobs.h
    M raster/r.solute.transport/main.c
    M raster/r.spread/ram2out.c
    M raster/r.stats/cell_stats.c
    M raster/r.stats/raw_stats.c
    M raster/r.sun/local_proto.h
    M raster/r.sun/rsunlib.c
    M raster/r.surf.contour/addpts.c
    M raster/r.thin/thin_lines.c
    M raster/r.to.rast3/main.c
    M raster/r.to.rast3elev/main.c
    M raster/r.to.vect/areas.c
    M raster/r.univar/r.univar_main.c
    M raster/r.univar/r3.univar_main.c
    M raster3d/r3.cross.rast/main.c
    M raster3d/r3.in.ascii/main.c
    M raster3d/r3.in.v5d/main.c
    M raster3d/r3.neighbors/main.c
    M raster3d/r3.out.ascii/main.c
    M raster3d/r3.out.netcdf/main.c
    M raster3d/r3.out.v5d/main.c
    M raster3d/r3.retile/main.c
    M raster3d/r3.to.rast/main.c
    M utils/timer/main.c
    M vector/v.delaunay/memory.c
    M vector/v.delaunay/memory.h
    M vector/v.external.out/list.c
    M vector/v.external/local_proto.h
    M vector/v.external/main.c
    M vector/v.kernel/global.h
    M vector/v.net.visibility/data_structures.c
    M vector/v.net.visibility/data_structures.h
    M vector/v.out.ogr/local_proto.h
    M vector/v.perturb/main.c
    M vector/v.perturb/perturb.h
    M vector/v.split/main.c
    M vector/v.to.db/parse.c
    M vector/v.to.db/update.c
    M vector/v.vol.rst/dataoct.h
    M vector/v.vol.rst/main.c
    M vector/v.vol.rst/oct.c
    M vector/v.vol.rst/oct.h
    M vector/v.vol.rst/user.h
    M vector/v.vol.rst/user1.c
    M vector/v.vol.rst/user3.c
    M vector/v.vol.rst/user4.c
    M vector/v.voronoi/sw_main.c

  Log Message:
  -----------
  Fix missing function prototypes (#2727)

This adds most, but not all, missing function prototypes.

Aaron Ballman from llvm, summarise: 
(https://discourse.llvm.org/t/rfc-enabling-wstrict-prototypes-by-default-in-c/60521):

> Functions without prototypes have never been a recommended practice
> in any standard version of C. In fact, they were introduced into C89
> as already being deprecated (see C89 3.9.4 and 3.9.5). After a 35+
> year deprecation period, C2x will be removing support for functions
> with identifier list
> (http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2432.pdf) and will be
> changing the behavior of prototypeless functions with empty parentheses
> to match the behavior of C++ (N 2841: No function declarators without
> prototypes).

a statement, which may provide as a short background as well as motivation
for this commit.




More information about the grass-commit mailing list