[GRASS-git] [OSGeo/grass-addons] 1767c5: v.surf.nnbathy: Fix exception type for Python 3 (#...

Vaclav Petras noreply at github.com
Thu Nov 9 12:37:34 PST 2023


  Branch: refs/heads/grass8
  Home:   https://github.com/OSGeo/grass-addons
  Commit: 1767c5f65fed3c5293f41668925558ea39c6e4ac
      https://github.com/OSGeo/grass-addons/commit/1767c5f65fed3c5293f41668925558ea39c6e4ac
  Author: Vaclav Petras <wenzeslaus at gmail.com>
  Date:   2023-11-09 (Thu, 09 Nov 2023)

  Changed paths:
    M src/vector/v.surf.nnbathy/nnbathy.py

  Log Message:
  -----------
  v.surf.nnbathy: Fix exception type for Python 3 (#981)

Fixes both v.surf.nnbathy and r.surf.nnbathy because r.surf.nnbathy imports the Python module installed with v.surf.nnbathy.

Fixes Pylint error E0602: Undefined variable 'StandardError' (undefined-variable), but introduces warning W0718: Catching too general exception Exception (broad-exception-caught).

This is aiming at making the tool run with Python 3 and GRASS GIS 8. Proper fix would separate try-except blocks to the relevant parts. Now two string splits, all vector handling and file writing are all in one try-except which catches everything including IndexError and AttributeError. This basic fix is just applying The Conservative Python 3 Porting Guide without further changes.




More information about the grass-commit mailing list