[GRASS-git] [OSGeo/grass] 195397: style: Fix self-assigning-variable (PLW0127) (#4137)

[Edouard Choinière]

  Branch: refs/heads/main
  Home:   https://github.com/OSGeo/grass
  Commit: 19539757c088a494366eb6381afc699f1064e2fd
      https://github.com/OSGeo/grass/commit/19539757c088a494366eb6381afc699f1064e2fd
  Author: Edouard Choinière <27212526+echoix at users.noreply.github.com>
  Date:   2024-08-09 (Fri, 09 Aug 2024)

  Changed paths:
    M gui/wxpython/animation/temporal_manager.py
    M gui/wxpython/psmap/frame.py
    M gui/wxpython/psmap/instructions.py
    M pyproject.toml
    M python/grass/temporal/core.py
    M temporal/t.rast.accdetect/t.rast.accdetect.py
    M temporal/t.rast.accumulate/t.rast.accumulate.py

  Log Message:
  -----------
  style: Fix self-assigning-variable (PLW0127) (#4137)

* style: Fix self-assigning-variable (PLW0127)

* PLW0127: python/grass/temporal/core.py: The last change on this line was removing decode(mapset) for python 3.

* temporal/t.rast.accumulate/t.rast.accumulate.py:283:13: PLW0127 Self-assignment of variable `upper`
Following the patterns from the same file, it seems that it is the map id that is wanted

* temporal/t.rast.accdetect/t.rast.accdetect.py:241:13: PLW0127 Self-assignment of variable `indicator`

Usage seemed to mean to set the map id instead.

* gui/wxpython/psmap/instructions.py: PLW0127 Self-assignment of variables in EstimateWidth, EstimateHeight, and EstimateSize

* gui/wxpython/psmap/frame.py:2234:17: PLW0127 Self-assignment of variable `zoomFactor`

* Change `not` usage to `<=`

* gui/wxpython/animation/temporal_manager.py:292:21: PLW0127 Self-assignment of variable `end`
Removed assignment

* Apply ruff suggestion for collapsible-else-if (PLR5501)



To unsubscribe from these emails, change your notification settings at https://github.com/OSGeo/grass/settings/notifications