[GRASS-git] [OSGeo/grass] 2cf98d: style: Fix unnecessary-dunder-call (PLC2801) (#4170)

Edouard Choinière noreply at github.com
Mon Aug 19 13:31:58 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/OSGeo/grass
  Commit: 2cf98dac35a6a3d2ab14120a68e345ff7609ba7d
      https://github.com/OSGeo/grass/commit/2cf98dac35a6a3d2ab14120a68e345ff7609ba7d
  Author: Edouard Choinière <27212526+echoix at users.noreply.github.com>
  Date:   2024-08-19 (Mon, 19 Aug 2024)

  Changed paths:
    M gui/wxpython/gcp/manager.py
    M gui/wxpython/gmodeler/canvas.py
    M gui/wxpython/gmodeler/model.py
    M gui/wxpython/gmodeler/panels.py
    M gui/wxpython/image2target/ii2t_manager.py
    M gui/wxpython/mapdisp/main.py
    M gui/wxpython/photo2image/ip2i_manager.py
    M gui/wxpython/tplot/frame.py
    M pyproject.toml
    M python/grass/gunittest/utils.py
    M python/grass/pygrass/gis/region.py
    M python/grass/pygrass/modules/interface/typedict.py
    M python/grass/pygrass/raster/abstract.py
    M python/grass/pygrass/raster/category.py
    M python/grass/pygrass/vector/__init__.py
    M python/grass/pygrass/vector/basic.py
    M python/grass/pygrass/vector/geometry.py
    M python/grass/pygrass/vector/table.py
    M python/grass/pygrass/vector/testsuite/test_geometry_attrs.py

  Log Message:
  -----------
  style: Fix unnecessary-dunder-call (PLC2801) (#4170)

* style: Fix unnecessary-dunder-call (PLC2801)

Ruff rule: https://docs.astral.sh/ruff/rules/unnecessary-dunder-call/

12 instances fixed. Solves some reported issues by Pylint 3.2.6 through unnecessary-dunder-call / C2801

* style: Fix unnecessary-dunder-call (PLC2801) for __init__
4 instances fixed

* style: Fix unnecessary-dunder-call (PLC2801) using getattr
6 instances fixed

* Ignore PLC2801 in test suite file for preserving meaning of test during the change

* style: Fix unnecessary-dunder-call (PLC2801) for get and set item
3 instances fixed

* style: Fix unnecessary-dunder-call (PLC2801) for repr
1 instance fixed

* Ignore PLC2801 for __del__, as there seems to be some differences between both

* Update pyproject.toml to remove PLC2801 exclusion

* gui.wxpython.mapdisp.main: Remove next(self) from LayerList

* grass.pygrass.vector: Remove next(self) from vector class (old Python 2 iterator)

* Revert "grass.pygrass.vector: Remove next(self) from vector class (old Python 2 iterator)"

This reverts commit f79172c1bcb69df75e51d76ca27c78d41307ed7a.

* Revert "gui.wxpython.mapdisp.main: Remove next(self) from LayerList"

This reverts commit 9963dd16ad0e73ea6111c86125e3ff5c61cd3da2.



To unsubscribe from these emails, change your notification settings at https://github.com/OSGeo/grass/settings/notifications


More information about the grass-commit mailing list