[GRASS-git] [OSGeo/grass] 8c5639: r.horizon: get rid of global variables and other r...

[Anna Petrasova]

  Branch: refs/heads/main
  Home:   https://github.com/OSGeo/grass
  Commit: 8c5639720edfdff18145ec539acf349bd18b0de1
      https://github.com/OSGeo/grass/commit/8c5639720edfdff18145ec539acf349bd18b0de1
  Author: Anna Petrasova <kratochanna at gmail.com>
  Date:   2024-03-22 (Fri, 22 Mar 2024)

  Changed paths:
    R raster/r.horizon/TODO
    R raster/r.horizon/local_proto.h
    M raster/r.horizon/main.c
    M raster/r.horizon/testsuite/test_r_horizon.py

  Log Message:
  -----------
  r.horizon: get rid of global variables and other refactoring (#3346)

Refactored r.horizon to make it possible to extend it in the future (e.g. multiple coordinates, parallelization, etc.), Refactoring includes

* removing most global variables and reorganizing them into structures depending on when the variables change and when they don't, e.g. member variables in new struct OriginAngle are constant for each origin point and angle computed. 
 * reducing the scope of some local variables
 * renaming/reorganizing some functions
 * reducing the code duplication between the point and raster mode
 * removing unused functions
 * addressing cppcheck complaints
 * adding a test comparing values of raster mode result with point mode results for couple points

I tried not do any changes that could impact results, e.g. there is still some discrepancy in how maxlength is computed for the  modes.



To unsubscribe from these emails, change your notification settings at https://github.com/OSGeo/grass/settings/notifications