[GRASS-git] [OSGeo/grass] f7537c: lib/ogsf: fix possible overflow errors in gsd_surf...

[Mohan Yelugoti]

  Branch: refs/heads/main
  Home:   https://github.com/OSGeo/grass
  Commit: f7537c41c00dbf9f5e5253aca412c1e4100d4a99
      https://github.com/OSGeo/grass/commit/f7537c41c00dbf9f5e5253aca412c1e4100d4a99
  Author: Mohan Yelugoti <ymdatta.work at gmail.com>
  Date:   2024-11-05 (Tue, 05 Nov 2024)

  Changed paths:
    M lib/ogsf/gsd_surf.c

  Log Message:
  -----------
  lib/ogsf: fix possible overflow errors in gsd_surf.c (#4635)

ogsf: fix possible overflow errors in gsd modules

In a lot of places, `(255 << 24)` which causes integer overflow
and positive number gets converted to negative number. We
were then assigning this to an unsigned integer in multiple
places, which does conversion in a different way.

For example: If we do unsigned int x = -20, `UINT_MAX + 1 - 20`
is assigned to x.

I do not think that's what is intended when we do
`ktrans = (255 << 24)`. Fix instances of that, by using an
unsigned int literal over int literal.

This issue was found using cppcheck tool.

Signed-off-by: Mohan Yelugoti <ymdatta.work at gmail.com>



To unsubscribe from these emails, change your notification settings at https://github.com/OSGeo/grass/settings/notifications