[GRASS-git] [OSGeo/grass] 206cab: lib/ogsf: fix possible overflow errors in gsd_wire...

[Mohan Yelugoti]

  Branch: refs/heads/main
  Home:   https://github.com/OSGeo/grass
  Commit: 206cabcbb7275debed2bcdd9c1a3869ab58552fc
      https://github.com/OSGeo/grass/commit/206cabcbb7275debed2bcdd9c1a3869ab58552fc
  Author: Mohan Yelugoti <ymdatta.work at gmail.com>
  Date:   2024-11-05 (Tue, 05 Nov 2024)

  Changed paths:
    M lib/ogsf/gsd_wire.c

  Log Message:
  -----------
  lib/ogsf: fix possible overflow errors in gsd_wire.c (#4636)

ogsf: fix possible overflow errors in gsd_wire

In a code, we were doing `(255 << 24)` which causes integer overflow
and positive number gets converted to negative number. We were then
assigning this to an unsigned integer in multiple places, which does
conversion in a different way.

For example: If we do `unsigned int x = -20`, `UINT_MAX + 1 - 20` is
assigned to x.

I do not think that's what is intended when we do with `ktrans = (255 <<
24)`. Fix instances of that, by using an `unsigned int literal`
over `int literal`.

This issue was found using cppcheck tool.

Signed-off-by: Mohan Yelugoti <ymdatta.work at gmail.com>



To unsubscribe from these emails, change your notification settings at https://github.com/OSGeo/grass/settings/notifications