[GRASS-git] [OSGeo/grass] 7fbaa7: style: Enable checking for pep8-naming (N) rules w...

[Edouard Choinière]

  Branch: refs/heads/main
  Home:   https://github.com/OSGeo/grass
  Commit: 7fbaa7e5a1b7cfe4fa3701a4ecfef51547843269
      https://github.com/OSGeo/grass/commit/7fbaa7e5a1b7cfe4fa3701a4ecfef51547843269
  Author: Edouard Choinière <27212526+echoix at users.noreply.github.com>
  Date:   2024-10-20 (Sun, 20 Oct 2024)

  Changed paths:
    M gui/wxpython/mapswipe/frame.py
    M pyproject.toml
    M python/grass/pygrass/modules/interface/testsuite/test_modules.py
    M python/grass/script/tests/test_script_task.py
    M raster/r.basins.fill/testsuite/testrbf.py
    M raster/r.series/testsuite/test_r_series.py
    M raster/r.terraflow/testsuite/test_r_terraflow.py
    M raster/r.to.vect/testsuite/test_r_to_vect.py
    M raster/r.viewshed/testsuite/test_r_viewshed.py
    M scripts/r.import/testsuite/test_r_import.py
    M scripts/r.reclass.area/testsuite/testrra.py
    M scripts/v.import/testsuite/test_v_import.py
    M vector/v.extract/testsuite/test_v_extract.py
    M vector/v.net/testsuite/test_v_net.py
    M vector/v.random/testsuite/test_v_random.py
    M vector/v.select/testsuite/test_v_select.py
    M vector/v.to.3d/testsuite/test_vto3d.py

  Log Message:
  -----------
  style: Enable checking for pep8-naming (N) rules with ruff, fix N804, N805 and N813 (#4556)

* style: Enable checking for pep8-naming (N) rules with Ruff

Rules already respected:
- dunder-function-name (N807)
- constant-imported-as-non-constant (N811)
- camelcase-imported-as-acronym (N817)

* style: Fix invalid-first-argument-name-for-class-method (N804)

Ruff rule: https://docs.astral.sh/ruff/rules/invalid-first-argument-name-for-class-method/

Two files had class methods that didn't use cls as their first argument

* style: Fix camelcase-imported-as-lowercase (N813)

Ruff rule: https://docs.astral.sh/ruff/rules/camelcase-imported-as-lowercase/

One instance only in a pytest file

* style: Fix invalid-first-argument-name-for-method (N805)

Ruff rule: https://docs.astral.sh/ruff/rules/invalid-first-argument-name-for-method/

Three instances in gui/wxpython/mapswipe/frame.py were ignored, as an inner class is defined using self2 and also references self from the containing class.



To unsubscribe from these emails, change your notification settings at https://github.com/OSGeo/grass/settings/notifications