[GRASS-git] [OSGeo/grass] c80a5d: gui: Actually raise GExceptions in iscatt_core (#7...

Edouard Choinière noreply at github.com
Sun Jul 12 01:27:46 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/OSGeo/grass
  Commit: c80a5d3b4aa1ff6415ec25dc9b879d3970598be3
      https://github.com/OSGeo/grass/commit/c80a5d3b4aa1ff6415ec25dc9b879d3970598be3
  Author: Edouard Choinière <27212526+echoix at users.noreply.github.com>
  Date:   2026-07-12 (Sun, 12 Jul 2026)

  Changed paths:
    M gui/wxpython/iscatt/core_c.py
    M gui/wxpython/iscatt/iscatt_core.py

  Log Message:
  -----------
  gui: Actually raise GExceptions in iscatt_core (#7659)

* gui: Actually raise GExceptions in iscatt_core

Some code in iscatt was not raising the exception it was creating.
Thus, it was not having any effect.

Here is the PR text for one of the fixes that was generated by AI. I
did the others.
General fix: when an error condition is detected, **raise** the
exception instead of just constructing it.

Best fix here: in `gui/wxpython/iscatt/iscatt_core.py`, inside
`CatRastUpdater._updateCatRast`, change line 277 from:
- `GException(_("Patching category raster conditions file failed."))`
to:
- `raise GException(_("Patching category raster conditions file
failed."))`

This preserves intended functionality (error reporting via
`GException`) while ensuring the failure is not silently ignored. No
new imports, methods, or definitions are required.

* Apply suggestions from code review



To unsubscribe from these emails, change your notification settings at https://github.com/OSGeo/grass/settings/notifications


More information about the grass-commit mailing list