[GRASS5] Changes to src/libes/gis/env.c

[Justin Hickey]

Hello Roger

On Jul 11,  1:59pm, Roger Bivand wrote:
> Please note the (few) changes I made recently in env.c. They are related
> to the ongoing discussion of the library API to libgis.a functions needed
> by interfaces to other programs that link against libgis.a - the key thing
> is never to expose an unprotected exit(); - always call
> G_fatal_error(); first, so that any user-provided error handler is called
> first, stopping say env.c functions clobbering the program linked to
> libgis.a. env.c had a couple of bad exits, I hope I found the worst ones.

Yes, I saw your changes and will keep this advice in mind. Thank you for
reminding me. I have one question though. I noticed that in some cases, there
is a return statement after a call to G_fatal_error(), but G_fatal_error()
contains a call to exit(). Therefore, is the return call just to keep the
compiler happy, or is it there for another reason? I seem to remember getting
hundreds of warnings about functions that had a return type but did not end in
a return statement during compiling.

> Otherwise good ideas!

Thank you.

-- 
Sincerely,

Jazzman (a.k.a. Justin Hickey)  e-mail: jhickey at hpcc.nectec.or.th
High Performance Computing Center
National Electronics and Computer Technology Center (NECTEC)
Bangkok, Thailand
==================================================================
People who think they know everything are very irritating to those
of us who do.  ---Anonymous

Jazz and Trek Rule!!!
==================================================================

---------------------------------------- 
If you want to unsubscribe from GRASS Development Team mailing list write to:
minordomo at geog.uni-hannover.de with
subject 'unsubscribe grass5'