[GRASS5] Re: WinGrass binary.

[Markus Neteler]

Hi Mike,

(cc to grass5)

On Tue, May 29, 2001 at 11:48:48AM +1000, Mike Thomas wrote:
> Hi again.
> 
> SUMMARY: I fixed the NVIZ and PNGDriver link problems, but left the
> r.fill.dir one till later.  Fixes below.  Made a new installation which is
> available as noted in my other email today.

Thanks - download is running...

> NVIZ is compiled, but won't run unless you put init.tcl in a new directory -
> "<GRASS-INSTALL-DIR>/etc/share/tcl8.0".
> 
> After fixing this, when run from tcltk, it then gives a usage message in an
> XTERM and stops gracefully.

[below more]

> DETAILS:
> > > (http://www.geog.uni-hannover.de/grass/grass5/source/), rather than the
> > > CVS pre-release tag, which has given me some inconsistent build results.
> > mhhh, that's surprising as it should be identical.
> 
> My guess is that when I did a CVS update in the tagged source I may have
> accidentally brought in files from other parts of the CVS.
> 
> Is just "cvs update" OK in the tagged source?
Check if you have the Treleasebranch_11_april_2001_5_0_0 applied (check
CVS/Entries). If so, you can run 
 cvs update -dP

to update it (last night another Xdriver fix from Glynn appeared).

> > > To avoid further delays, r.fill.dir, PNGDRIVER and NVIZ are not in the
> > > distribution, as I had troubles building each of them.
> > Please be so kind and send the error messages, especially of r.fill.dir.
> 
> The configure seems to have incorrectly dealt with "values.h".  I'll look
> into it today.

That's easy to fix:

> #################################################################
> /cygdrive/e/cvs/grass5.0.0pre1/src/raster/r.fill.dir
>   mkdir OBJ.i686-pc-cygwin
>   make -f OBJ.i686-pc-cygwin/make.rules
> 
> make[1]: Entering directory
> `/cygdrive/e/cvs/grass5.0.0pre1/src/raster/r.fill.dir'
> gcc -g -O2  -I/cygdrive/e/cvs/grass5.0.0pre1/src/include   -c main.c -o
> OBJ.i686-pc-cygwin/main.o
> In file included from main.c:54:
> tinf.h:3: values.h: No such file or directory

Change it to "limits.h":

Index: tinf.h
===================================================================
RCS file: /grassrepository/grass/src/raster/r.fill.dir/Attic/tinf.h,v
retrieving revision 1.1.2.2
diff -r1.1.2.2 tinf.h
3c3
< #include <values.h>
---
> #include <limits.h>

values.h is the old, obsolete name for limits.h. I have updated in CVS as
well.

> > For PNGDriver I assume problems with libgd, and NVIZ?
> 
> PNGDriver's Gmakefile puts  ${PNGLIB} before ${GDLIB} which means that the
> libgd references to libpng don't get resolved at link time.  I swapped them
> around and it linked fine.  I'll redo the binary package.  The fixed line
> is:
> 
> $(GISBASE)/driver/PNG: $(OFILES) ${DRIVERLIB} ${GISLIB}
>  ${CC} $(LDFLAGS) -o $@ $(OFILES) ${DRIVERLIB} ${GISLIB} $(GRAPH) $(ZLIB)
> ${GDLIB} ${PNGLIB} $(MATHLIB) $(XDRLIB)

Thanks, fixed as well in CVS.

> Why didn't anyone report that problem?

Well, the gcc compiler seem to be able to live with the reversed order.
Both versions compile well here. Anyway, it is reversed now.

> Built now and and put in the binary package.
> 
> 
> NVIZ -
> 
> Two problems -
> 
> 1. Some libX11 symbols were not being resolved.  To
> "NVIZ2.2/src/gmakefile.in" I made this change (added $XLIB, probably just
> needs reordering of the OGLLIB macro, but this is quicker):
> 
> nvwish: $(OBJS) $(VECTLIB) $(BITMAPLIB) $(LINKMLIB)
>  $(CC) -g -o $@ $(OBJS) $(LDFLAGS) $(SURFLIB) $(IMGLIB) \
>  $(BITMAPLIB) $(LINKMLIB) $(VECTLIB) \
>  $(GISLIB) $(MATHLIB) $(XDRLIB) \
>  $(LIBDIR)/libdatetime.a $(XTRA_LDFLAGS) -ltiff $(XLIB)
> 
> 2. The install target in "NVIZ2.2/Gmakefile" fails to mv the nvwish.exe, as
> it leaves out the .exe extension.  This mod at the end of the target does
> the job:
> 
> install:
> ..................
>  if test -f "src/nvwish" ; then mv src/nvwish.exe
                                               ^^^^- without .exe
> $(INSTALL_DIR)/$(NVWISH_VER) ; fi
>  if test -f "src/nvwish.exe" ; then mv src/nvwish.exe
> $(INSTALL_DIR)/$(NVWISH_VER) ; fi

Thanks, both fixes are applied to CVS. However, doesn't need $(NVWISH_VER)
the .exe extention as well for winGRASS (second case)? Something like:

 if test -f "src/nvwish.exe" ; then mv src/nvwish.exe $(INSTALL_DIR)/$(NVWISH_VER).exe ; fi

> > > v.digit /backdrop cell map hangs 
> > Oops. How does it hang? Does it crash or doesn't it display the map?
>
> The entire bash session hangs without displaying the map.  I have to kill
> the shell and v.digit.
> 
> I tried commenting out the loop in "drawcell()" but it still hangs.  My wife
> got cranky so I had to stop and look after the children after that!  I
> haven't had time at work yet to go further on this problem.
> 
> Time to get back to making a living for a few hours.
> 
> Cheers
> Mike Thomas

Perhaps Glynn could recommend on the v.digit problem.

Thanks, Mike, for your fixes,


 Markus