[GRASS5] Re: [GRASS-CVS] CVS update: grass/src/display/devices/CELL

[Glynn Clements]

Markus Neteler wrote:

> the recent changes to XDRIVER introduced a bug:
> 
> Try:
> export GRASS_HEIGHT=100
> d.mon x0
>  using default visual which is TrueColor
>  ncolors: 65536
>  Graphics driver [x0] started
> 
> d.mon stop=x0 
> 
> export GRASS_HEIGHT=   
> 
> d.mon x0
>  using default visual which is TrueColor  
>  X Error of failed request:  BadValue (integer parameter out of range for
>  operation)

[snip]

> Please pre-define the variable if unset (will also affect GRASS_WIDTH,
> unchecked).

OK, done.

> Then a question: Now PNGDriver and Xdriver use the same size variables
> GRASS_HEIGHT and GRASS_WIDTH (or not?).

Yes; all monitors now use these variables. The intention was to make
it easier for programs which manage monitors, so that they don't need
a table of which monitor uses which variables.

If you want per-monitor-type variables, it would be better to
generalise the mechanism using the driver name, e.g. with something
like GRASS_WIDTH_XDRIVER, GRASS_WIDTH_PNG, GRASS_WIDTH_CELL etc rather
than having a special case for one of the drivers.

-- 
Glynn Clements <glynn.clements at virgin.net>