[GRASS5] Re: [GRASS-CVS] david: grass/src/mapdev/v.in.shape

[David D Gray]

Markus Neteler wrote:
> Below fixes from David suggest further testing. Since v.in.shape is
> an important module this seems to be another indicator for pre5 (as
> well as the r.proj/datum issues).
> 
> Markus
> 
> On Wed, Jun 12, 2002 at 02:03:10AM +0200, grass at intevation.de wrote:
> 
>>Author: david
>>
>>Update of /grassrepository/grass/src/mapdev/v.in.shape
>>In directory doto:/tmp/cvs-serv8535
>>
>>Modified Files:
>>	basename.c lines.c main.c polygon.c vmap_import.c 
>>Log Message:
>>
>>Final cleanup, preparing for release. Now considered ready for release. Most
>>significantly the 'sliver' option is removed as it is not required in
>>the current (or future) versions.
>>
>>[...]

Hi Markus, folks

I have a break just now and will be on this list till Monday.
The changes are really mostly cosmetic, such as changes to warning and 
error messages and their verbosity levels, removing pieces of code that 
generate warnings: `x declared but not used' and the like, and minor but 
not critical coding errors. The only change in functional code was the 
corrrections to the line reading section comitted yesterday. the removal 
of the `sliver' option may seem dramatic, but in fact it is also just a 
cleanup op - this option was no-where used in the new module. Only this 
might affect scripts that people have that use the option. The 
documentation is updated.

Apart from bugfixes, should any turn up, I don't plan to change this 
now. Given this I don't think this needs extensive testing (I have 
tested quite a lot of files, only change: the known bug is fixed) and so 
shouldn't hold up the GRASS 5.0.0 release schedule to any extent.

Code that does some cleaning ops is worth having, but this should be 
developed in the context of the development version, and along with 
efforts to integrate vector import, through an interface like OGR. A 
small part could be back-ported as a module to a later 5.0.x version for 
some simple ops that the current vector lib can support.

David