[GRASS5] Re: [GRASSLIST:5585] Re: GRASS 5.0.1 compilation issues

Glynn Clements glynn.clements at virgin.net
Mon Feb 17 16:25:48 EST 2003


[Moved to dev list]

Wayne Gibson wrote:

> Running d.where also had some troubles. When I issued the command,
> an endless stream of coordinate were displayed until I made the 1st
> mouse click. Then the command worked as it should (1 pair of
> coordinates per mouse click).

This was broken by this change:

  revision 1.2
  date: 2000/08/25 15:55:07;  author: cho;  state: Exp;  lines: +2 -0
  modified R_get_location_with_pointer() to get mouse location without click.
  
  Setting button < 0 before calling this function helps you with checking
  mouse location without click or move.

If you change the behaviour of a library function, you also have to
change all of the programs which relied upon the old behaviour.

In this specific case, the contents of the location to which the third
argument of R_get_location_with_pointer() points used to be ignored
upon input. Typically it will point to an uninitialised variable; if
that variable happens to contain -1, the program will fail.

As I can't find a single program which actually depends upon the
changed behaviour, I am reverting the change.

-- 
Glynn Clements <glynn.clements at virgin.net>




More information about the grass-dev mailing list